Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Xls writer wrong cells and sheet selection. #1256

Merged
merged 1 commit into from Mar 2, 2020

Conversation

jimmy4o4
Copy link
Contributor

@jimmy4o4 jimmy4o4 commented Nov 25, 2019

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

See #1250 .

@jimmy4o4 jimmy4o4 force-pushed the master branch 3 times, most recently from 64bf016 to e0f5824 Compare November 25, 2019 10:23
Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement, but we would need to cover it with testing. You can have a look at \PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional and sibling classes to see how to test writing and reading files.

@PowerKiKi PowerKiKi added missing test writer/xls Writer for MS BIFF-format (xls) spreadsheet files labels Nov 30, 2019
@jimmy4o4
Copy link
Contributor Author

Fix for Xls BIFF window2 structure was needed too.

I've added some tests too.

All of this covers only problems with Xls. Ods and Xlsx are still affected, I'm not sure, if there is any possible solution for these file types.

@PowerKiKi PowerKiKi merged commit 06d9dc0 into PHPOffice:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing test writer/xls Writer for MS BIFF-format (xls) spreadsheet files
Development

Successfully merging this pull request may close these issues.

None yet

2 participants