fix implicit cast deprecation in php8.1 #2210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a php8.1 deprecation issue. Behaviour has not changed, as implicit cast exist at least since PHP8.0, but previously not thrown a deprecation error.
|
Sry, didn't saw this other PR. Yes, the other PR should also fix the issue. Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a php8.1 deprecation issue. Behaviour has not changed, as implicit cast exist at least since PHP8.0, but previously not thrown a deprecation error.
This pull only contains the fix without changes to documentation, changelogs or unit test. Hope this can be done by someone else, as i don't have time to invest more time here.
This is:
Checklist:
Why this change is needed?
Starting with PHP8.1, implicit casts from float to int/string is now deprecated.