Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Phpstan Messages in Writer Ods #3342

Merged
merged 3 commits into from Feb 6, 2023

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Feb 3, 2023

Reduce number of Phpstan messages by addressing their issues.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Reduce number of Phpstan messages by addressing their issues.
Phpstan reports one fewer error under Php8 than previously.
@oleibman oleibman merged commit 14fd9bd into PHPOffice:master Feb 6, 2023
@oleibman oleibman deleted the stanwriterods branch March 2, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant