Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize 'Hidden' Attribute and Other Unsupported Options in Xml Spreadsheet #3567

Merged
merged 8 commits into from May 18, 2023

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented May 14, 2023

Fix #3566. Fix #3568. Fix #3569. PhpSpreadsheet should now handle Hidden attribute for rows and columns in Xml spreadsheets. Also added the ability to load Xml spreadsheet from string rather than file, as can be done for Csv and Html.
Also:

  • top left Cell
  • check value for font Bold/Italic rather than always setting to true
  • read active sheet index from Xml
  • set selected cell(s) on each worksheet
  • worksheet protection (sheet only)
  • style protection
  • better handling of default style
  • column spans in xml

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Fix PHPOffice#3566; PhpSpreadsheet should now handle Hidden attribute for rows and columns in Xml spreadsheets. Also added the ability to load Xml spreadsheet from string rather than file, as can be done for Csv and Html.
Another missing piece.
@oleibman oleibman changed the title Recognize 'Hidden' Attribute in Xml Spreadsheet Recognize 'Hidden' Attribute and Other Unsupported Options in Xml Spreadsheet May 15, 2023
Was always setting to true rather than checking value for 0/1.
Had always been set to hard-coded 0. Read it from XML if available.
Get Selected Cells from XML when available.
Add support for those to Xml Reader.
Not really an essential part of Excel, used in Xml to reduce file size.
@oleibman oleibman merged commit 482fe6d into PHPOffice:master May 18, 2023
12 checks passed
@oleibman oleibman deleted the issue3566 branch June 9, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant