-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address issue #86 #87
Conversation
missed the tests |
Thanks. Add me as a reviewer when you think it is ready and I'll pull it down and test it. |
- Make lower case ph5.core classes uppercase - Fix kefx import from previous refactor
I changed all lower case class names to uppercase to follow PEP8 and also fixed a few issues I found when reviewing the initial renaming of modules. In my opinion this is ready. |
thanks right after lunch I'll run a small set of raw data into ph5 then output it in a few formats. Should only take about 45 mins or so, but will test most of the programs from start ti finish. |
Okay after that small change I think everything is good. I was able to use all the gui programs and command line tools to load some raw rt125 data into ph5, check everything with table2kef then output miniseed and SAC. I think this is ready |
Good catch. Should I go ahead and squash merge? |
Yeah, should be good to go. |
Renamed files, updated instances and updated setup.py
This will need to be tested extensively. I did check that every utility and client at least ran