Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue #86 #87

Merged
merged 7 commits into from
Jul 19, 2017
Merged

Address issue #86 #87

merged 7 commits into from
Jul 19, 2017

Conversation

derick-hess
Copy link
Contributor

Renamed files, updated instances and updated setup.py

This will need to be tested extensively. I did check that every utility and client at least ran

@derick-hess
Copy link
Contributor Author

missed the tests

@nick-falco
Copy link
Collaborator

Thanks. Add me as a reviewer when you think it is ready and I'll pull it down and test it.

@nick-falco
Copy link
Collaborator

I changed all lower case class names to uppercase to follow PEP8 and also fixed a few issues I found when reviewing the initial renaming of modules. In my opinion this is ready.

@nick-falco nick-falco changed the title Address issue #86 Fix #86 Jul 19, 2017
@nick-falco nick-falco changed the title Fix #86 Address issue #86 Jul 19, 2017
@derick-hess
Copy link
Contributor Author

thanks right after lunch I'll run a small set of raw data into ph5 then output it in a few formats. Should only take about 45 mins or so, but will test most of the programs from start ti finish.

@derick-hess
Copy link
Contributor Author

Okay after that small change I think everything is good. I was able to use all the gui programs and command line tools to load some raw rt125 data into ph5, check everything with table2kef then output miniseed and SAC.

I think this is ready

@nick-falco
Copy link
Collaborator

Good catch. Should I go ahead and squash merge?

@derick-hess
Copy link
Contributor Author

Yeah, should be good to go.

@nick-falco nick-falco merged commit d6c428b into master Jul 19, 2017
@nick-falco nick-falco deleted the fix#86 branch July 19, 2017 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants