edit history testing #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
PIG208
force-pushed
the
JSON-testing
branch
2 times, most recently
from
c4611aa
to
e752edd
Compare
This is the first migration to migrate edit_history field of AbstractMessage model from TextField to JSONField. This migration just adds the edit_history_entries field in the model. Co-Authored-By: Zixuan James Li <p359101898@gmail.com>
We cast edit_history because it already stores valid JSON consistently. Skipping the null values because we want to fall back to "[]" in that case. We also implement double-write for edit_history_entries so that we have a window to run the backfilling migration without downtime or extensive locking, which also prepares us to stop using the edit_history field. Co-Authored-By: Zixuan James Li <p359101898@gmail.com>
PIG208
force-pushed
the
JSON-testing
branch
3 times, most recently
from
89c89d9
to
ae97bfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs the tests without the third final commit