New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to IndexedDb #121
Switch to IndexedDb #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK cba2b4f
Does as it is intended to, for now, can verify the storage, added MN, verified both networks available, and settings are stored.
Chrome & Safari
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still able to replicate the 'Promise' issue, this time upon trying an Encrypted Import (an MPW encrypted legacy WIF, to be exact):
Uncaught (in promise) DOMException: Promise object could not be cloned.
addAccount database.js:69
InterpretGeneratorResume self-hosted:1819
AsyncFunctionNext self-hosted:807
(Async: async)
guiImportWallet global.js:1159
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK e46e787.
I have tested everything I can think of - every single setting, every import type, with/without encryption, wiped the IndexedDB a billion times between each test, and also ran through the 'migration' many times by wiping IndexedDB
while my localStorage
data remained.
This is awesome! 🎉
LGTM, this will be a great futureproofing for MPW's 'heavier' capabilities in the future (i.e: Sapling Storage, or Block Headers, etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK e46e787
Still working 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 77643aa really nice work
Abstract
Switches to IndexedDb, compared to localStorage, it has the following features:
-testnet
to our keys anymorehave a better database than local storage, by having a larger capacity, a versioning system to easily update the database and doesn't block the UI.