Fix CoinGecko spam (finally) #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just ensures that, even if CoinGecko fails to respond, it won't prevent the user's balance from loading.
Liquid369
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
There were some redundant calls towards the CoinGecko API at startup (Both
global.js start()andsettings.js start()were fetching prices at startup, that was fixed).Additionally, a race condition was possible where if CoinGecko did NOT sync prices prior to your UTXOs, then each UTXO would individually call CoinGecko due to cache not being fulfilled.
Now, the startup is guaranteed to only call once, and then the UTXOs syncs afterwards - if CoinGecko fails, UTXOs will continue to sync as normal.