Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Payment Requests #140

Merged
merged 2 commits into from Jun 2, 2023
Merged

Improved Payment Requests #140

merged 2 commits into from Jun 2, 2023

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Jun 1, 2023 •
edited

Abstract

This is a simple dual-bugfix for MPW Payment Requests, which previously suffered two bugs:

  • A request opened by a user without a wallet, would 'black screen' MPW.
  • A request's data (description, etc) would still remain after paying the request.

Both are now patched.

Testing

Simply click the below Payment Requests.

  • Test with an empty wallet (i.e; Private or Incognito tab).
  • Try fulfilling one, Production will not wipe info, the PR will.

The payment request on Production
The payment request on This PR

@JSKitty JSKitty added the Bug This is either a bugfix (PR) or a bug (issue). label Jun 1, 2023
@JSKitty JSKitty requested review from Liquid369, Duddino and a team June 1, 2023 16:38
@JSKitty JSKitty self-assigned this Jun 1, 2023
Liquid369
Liquid369 approved these changes Jun 2, 2023
View reviewed changes
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 047fa6c

Duddino
Duddino approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@JSKitty JSKitty merged commit 2423f3e into master Jun 2, 2023
5 checks passed
Liquid369 pushed a commit to Liquid369/MyPIVXWallet that referenced this pull request Aug 2, 2023
@JSKitty @Liquid369
Improved Payment Requests (PIVX-Labs#140)
f7cd4f5 
* fix: black screen on empty wallet + wipe after pay

* Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liquid369 Liquid369 Liquid369 approved these changes

@Duddino Duddino Duddino approved these changes

Assignees

@JSKitty JSKitty

Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
My PIVX Wallet v2.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JSKitty @Liquid369 @Duddino