Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity Improvements #141

Merged
merged 2 commits into from Jun 10, 2023
Merged

Activity Improvements #141

merged 2 commits into from Jun 10, 2023

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Jun 3, 2023

Abstract

This PR fixes a handful of Activity bugs, as well as improving it's general responsiveness and performance!

  • New transactions are synced faster.
  • Fixed TX history disappearing after Unlocking or Sending transactions.
  • Fixed unnecessary renders when there's no change to TX history.
  • Fixed the unused updateStakingRewardsGUI index import error.

The Dashboard Activity and Staking Reward history should now both be completely stable, fast, and with low resource usage. 馃帀

@JSKitty JSKitty added Bug This is either a bugfix (PR) or a bug (issue). Enhancement New feature or request labels Jun 3, 2023
@JSKitty JSKitty requested review from Liquid369, Duddino, PalmTreeVI, BreadJS and a team June 3, 2023 14:28
@JSKitty JSKitty self-assigned this Jun 3, 2023
Duddino
Duddino approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, as mentioned on discord, we can rewrite the Network code to have a state for non-blockbook explorers, but it would be overkill to implement in this PR

SKDTXL
SKDTXL approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@SKDTXL SKDTXL left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck e887b13: I ran a series of lengthy test on this Activity Improvements PR both on testnet and mainnet, as reported on discord, I am confirming that the Activity was greatly improved. No error detected so far, and it is working perfectly and as intended. This is ready for a merge.

@JSKitty JSKitty merged commit 9acc33d into master Jun 10, 2023
5 checks passed
Liquid369 pushed a commit to Liquid369/MyPIVXWallet that referenced this pull request Aug 2, 2023
@JSKitty @Liquid369
Activity Improvements (PIVX-Labs#141)
630cc0e 
* Fix Activity bugs and improve responsiveness

* Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Duddino Duddino Duddino approved these changes

@SKDTXL SKDTXL SKDTXL approved these changes

@Liquid369 Liquid369 Awaiting requested review from Liquid369

@PalmTreeVI PalmTreeVI Awaiting requested review from PalmTreeVI

@BreadJS BreadJS Awaiting requested review from BreadJS

Assignees

@JSKitty JSKitty

Labels
Bug This is either a bugfix (PR) or a bug (issue). Enhancement New feature or request
Projects
My PIVX Wallet v2.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JSKitty @Duddino @SKDTXL