Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cold Staking customisation UI #146

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Add Cold Staking customisation UI #146

merged 3 commits into from
Jun 26, 2023

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Jun 13, 2023

Abstract

This PR finally allows MPW users to customise (with persistence) their Cold Staking delegation address: allowing users to delegate to places outside of the PIVX Labs built-in Cold Pool.

image

image

The UI is sleek and simple, it also displays the currently-set Cold Staking address, explains the system a little bit, and then provides the input box to change the address to a preferred external address.

@JSKitty JSKitty added the Enhancement New feature or request label Jun 13, 2023
@JSKitty JSKitty requested review from Liquid369, Duddino and a team June 13, 2023 21:23
@JSKitty JSKitty self-assigned this Jun 13, 2023
Copy link
Member

@JsCodeTee JsCodeTee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 21e6962

Ok, I think this is a very cool new added feature!
With the Cold Staking customization, you can Stake outside of the MPW staking environment if you want to use other staking service. I ran a test on this in attempt to Stake using Allnodes platform. I was able to Stake using Allnodes Cold staking address but couldn't finish up the setup on Allnode site.
So, it allowed me to Stake using Allnode cold staking address by customizing Cold Staking address to Allnodes, without the need to use Allnode site platform. This means, anyone can Stake using Allnode Cold staking address right directly from MPW, or to any other Staking service outside of the MPW staking environment, directly from MPW. Good job!

The customized staking feature works perfectly and ready for a merge.

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK I like this. I think we should have a default testnet delegation address, but it's not really relevant to this PR

@JSKitty JSKitty merged commit 2bfa375 into master Jun 26, 2023
5 checks passed
@3point14159
Copy link

Looking forward to testing this feature. Is this live on the bleeding edge wallet?

Also, how's the cold staking from a Ledger device going?

@JSKitty
Copy link
Member Author

JSKitty commented Jun 28, 2023

I've just pushed the latest Master branch to Bleeding-Edge; enjoy!

I don't believe there's any progress on Ledger Cold Staking - efforts are in other areas right now (v1.0, Shield, Shield Staking), from what I recall, we'd need to work with Ledger to implement P2CS properly, rather than the awkward zcash-app-bypass required to use PIVX Cold Staking on Ledger right now.

@3point14159
Copy link

Thanks for the update. Gonna swing over to the bleeding-edge branch and play.

Looking forward to the new features! Love seeing the development cycle pick-up, especially as the market is becoming more excited over such scarce resources.

<3

@3point14159
Copy link

3point14159 commented Jun 28, 2023

Getting an error popup:

"Unhandled exception. InvalidStateError: A mutation operation was attempted on a database that did not allow mutations."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants