-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cold Staking customisation UI #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 21e6962
Ok, I think this is a very cool new added feature!
With the Cold Staking customization, you can Stake outside of the MPW staking environment if you want to use other staking service. I ran a test on this in attempt to Stake using Allnodes platform. I was able to Stake using Allnodes Cold staking address but couldn't finish up the setup on Allnode site.
So, it allowed me to Stake using Allnode cold staking address by customizing Cold Staking address to Allnodes, without the need to use Allnode site platform. This means, anyone can Stake using Allnode Cold staking address right directly from MPW, or to any other Staking service outside of the MPW staking environment, directly from MPW. Good job!
The customized staking feature works perfectly and ready for a merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK I like this. I think we should have a default testnet delegation address, but it's not really relevant to this PR
Looking forward to testing this feature. Is this live on the bleeding edge wallet? Also, how's the cold staking from a Ledger device going? |
I've just pushed the latest Master branch to Bleeding-Edge; enjoy! I don't believe there's any progress on Ledger Cold Staking - efforts are in other areas right now (v1.0, Shield, Shield Staking), from what I recall, we'd need to work with Ledger to implement P2CS properly, rather than the awkward zcash-app-bypass required to use PIVX Cold Staking on Ledger right now. |
Thanks for the update. Gonna swing over to the bleeding-edge branch and play. Looking forward to the new features! Love seeing the development cycle pick-up, especially as the market is becoming more excited over such scarce resources. <3 |
Getting an error popup: "Unhandled exception. InvalidStateError: A mutation operation was attempted on a database that did not allow mutations." |
Abstract
This PR finally allows MPW users to customise (with persistence) their Cold Staking delegation address: allowing users to delegate to places outside of the PIVX Labs built-in Cold Pool.
The UI is sleek and simple, it also displays the currently-set Cold Staking address, explains the system a little bit, and then provides the input box to change the address to a preferred external address.