Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testnet toggler now follows network state #152

Merged
merged 4 commits into from Jul 11, 2023
Merged

Conversation

BreadJS
Copy link

@BreadJS BreadJS commented Jul 9, 2023

What does this PR address?

When clicking on the testnet toggle in settings it was not following the network state. For example, when it failed to switch to testnet because of a loaded wallet, it still switched the toggle. This has now been fixed right now

How does this benefit users?

The users can now see the real state of the network with the toggler.

PIVX Address

DDS5v6mPqUN3rdzkp3268LV7TKjHCZqy8c

JSKitty
JSKitty previously requested changes Jul 9, 2023
Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits.

scripts/global.js Outdated Show resolved Hide resolved
scripts/settings.js Outdated Show resolved Hide resolved
@JSKitty JSKitty added the Bug This is either a bugfix (PR) or a bug (issue). label Jul 9, 2023
@JSKitty JSKitty requested review from Liquid369, Duddino and a team July 9, 2023 21:32
@JSKitty JSKitty dismissed their stale review July 11, 2023 15:49

Fixed them myself.

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 566e121

Fixed the nits myself, LGTM before v1.0.

Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 566e121

@JSKitty JSKitty merged commit b321a29 into master Jul 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants