Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Governance consensus rules #198

Merged
merged 2 commits into from Sep 18, 2023
Merged

Improve Governance consensus rules #198

merged 2 commits into from Sep 18, 2023

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Sep 17, 2023

Abstract

This proposal fixes a handful of small areas where MPW deviated from PIVX Core's Governance consensus rules, those being:

  • The 'Budget Fee' finalisation confirms: MPW now uses PIVX Core's rules for Mainnet and Testnet.
  • The 'Budget Fee' confirmation time (24h rule), for this, we use IsEstablished from the getbudgetinfo results.
    • I would have preferred computing confirm time in-MPW to reduce RPC reliance, but it felt overkill for a single bool.
  • Fixed how MN votes are computed, now MPW uses the exact same calculation without rounding, which stops Testnet 0 vote proposals from "Passing" due to Testnet's low MN count.

When a proposal falls under the '24h rule' (on Mainnet, it's 5m on Testnet) then the Governance Dashboard will signal this with a "Too Young" message, and will not allow it to pass or be funded.
image


Testing

To test this PR, it's suggested to attempt these user flows, or variations of these:

  • Compare PIVX.org with MyPIVXWallet (this PR), ensure the Passing and Funding states 100% match.

If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!


@JSKitty JSKitty added Bug This is either a bugfix (PR) or a bug (issue). Enhancement New feature or request labels Sep 17, 2023
@JSKitty JSKitty self-assigned this Sep 17, 2023
@JSKitty JSKitty marked this pull request as ready for review September 17, 2023 15:30
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment

scripts/global.js Show resolved Hide resolved
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 497263d

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 497263d

@JSKitty JSKitty merged commit ffb3b71 into master Sep 18, 2023
3 checks passed
@JSKitty JSKitty deleted the governance-24h-rule branch September 18, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue). Enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants