Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI error upon receiving MN Collateral #217

Merged
merged 1 commit into from Sep 27, 2023
Merged

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Sep 26, 2023

Abstract

A simple one-liner fix to a typo which caused the MN UI to error upon receiving a collateral (when no prior MN was setup).
image

It now displays as intended:
image


Testing

To test this PR, it's suggested to attempt these user flows, or variations of these:

  • Import or Create a wallet - mainnet or testnet.
  • Receive 10,000 PIV exactly.
  • Try to open the Masternode Dashboard.

If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!


@JSKitty JSKitty added the Bug This is either a bugfix (PR) or a bug (issue). label Sep 26, 2023
@JSKitty JSKitty self-assigned this Sep 26, 2023
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 6555c7e
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6512eff4672d2200082b4713
😎 Deploy Preview https://deploy-preview-217--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 6555c7e

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@JSKitty JSKitty merged commit b012664 into master Sep 27, 2023
7 checks passed
@JSKitty JSKitty deleted the mn-collateral-ui-fix branch September 27, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants