Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore immature txs #234

Merged
merged 7 commits into from Oct 16, 2023
Merged

Ignore immature txs #234

merged 7 commits into from Oct 16, 2023

Conversation

panleone
Copy link
Member

Abstract

Wallet can now recognize if a tx is Coinbase/Coinstake/mature or immature. Wallet will ignore immature txs since they cannot be spent yet


Testing

For devs: should be enough verifying that your coinbase/coinstake txs are recognized as such (use a console.log for example)

@netlify
Copy link

netlify bot commented Oct 14, 2023

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 216d79a
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/652ced20eb6fab00083572cc
😎 Deploy Preview https://deploy-preview-234--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@panleone panleone self-assigned this Oct 14, 2023
@panleone panleone changed the title Skip immature txs Ignore immature txs Oct 14, 2023
@panleone panleone added Enhancement New feature or request Bug This is either a bugfix (PR) or a bug (issue). labels Oct 14, 2023
@panleone panleone force-pushed the mempool_maturity branch 2 times, most recently from 6248271 to 2fa8351 Compare October 14, 2023 15:52
@Duddino Duddino marked this pull request as draft October 14, 2023 18:24
@Duddino Duddino marked this pull request as ready for review October 14, 2023 18:25
@Duddino
Copy link
Member

Duddino commented Oct 14, 2023

Sorry was playing with my git client and I drafted by mistake

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Activity list TXs seem to appear as 'Unconfirmed' now even long after maturing (although I'm aware this was broken before now, so at least it kinda works lol).
image

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the Activity still only displays Confirmed on all TXs now, this TX has only 2 confs, but is displaying as if fully confirmed.

image
image

Duddino
Duddino previously approved these changes Oct 16, 2023
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK other than the minor nit

scripts/mempool.js Outdated Show resolved Hide resolved
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 216d79a

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 216d79a

@JSKitty JSKitty merged commit 55a74a9 into PIVX-Labs:master Oct 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue). Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants