-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change address v2 #246
Change address v2 #246
Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 9ed971d
Balance fine in large testnet wallet, send/recv is fine and path shown is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good apart for two things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 0563adc, explorer looks good, External and Internal (change) chains working well, various TXs tested with various change amounts, Legacy Wallets are working fine as well (could not find any legacy regressions).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 0563adc
Abstract
(This is a rewrite of #221)
Add proper change address, deriving them using
m/44'/119'/0'/1/${nAccount}
(or equivalent for testnet/hardware wallets).All "internal" addresses, i.e. addresses that are not presented to the user, should derive this way.
Testing