i18n Modal Fixes #254
Merged
i18n Modal Fixes #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
panleone
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Some modals and minor UI elements were not rendering the i18n lang, defaulting to English, like the Seed Phrase creation or "Encrypt/Change Pass" modals, now it renders using i18n.
This PR also removes what seems to be "duplicated" HTML, since the Seed Phrase Vue template already contains the entire modal, the
index.htmldidn't need a clone of it.This PR also solves the
getParentLanguagefunction to fallback to English if a parent code isn't supported by MPW, for ex: missing lines fromES-MXwould fallback toES, but MPW does not haveES, so would throw errors trying to load it, those lines will cascade down to English worst case scenario.Lastly, a typo in
negotiateLanguageswas fixed that probably broke some underlying library functionality.Testing
To test this PR, it's suggested to attempt these user flows, or variations of these:
ES-MXloads correctly without errors.If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!