Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Double sync #257

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

panleone
Copy link
Member

@panleone panleone commented Nov 9, 2023

Abstract

Solves two bugs:

  1. Do not re-loadFromDisk and re-fullSync an already loaded loaded (this happened for example when wallet was unlocked);
  2. Disable togglet testnet and delete wallet if the wallet is not synced yet, or everything will break down.
  1. This is also a solution to Switching networks is buggy #202 . The solution is not very clean but until we do a big refactor of wallet/mempool/network this is the best we can do.

@panleone panleone self-assigned this Nov 9, 2023
@panleone panleone added the Bug This is either a bugfix (PR) or a bug (issue). label Nov 9, 2023
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 0675e83
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/654ce5a83b19ea0007853e42
😎 Deploy Preview https://deploy-preview-257--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 0675e83, good to have even a simple temporary solution to the failed network reqs when switching chains halfway through sync (especially effective now we store on disk for instant reloads).

Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 0675e83

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@JSKitty JSKitty merged commit 2f18af7 into PIVX-Labs:master Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants