Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Refresh Address" dropdown button visibility #263

Merged
merged 1 commit into from Nov 15, 2023

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Nov 13, 2023

Abstract

This PR simply fixes the "Refresh Address" button visibility, which was always 'off' as the Dashboard Vue component did not pass the loaded wallet types to the WalletBalance component.


Testing

To test this PR, it's suggested to attempt these user flows, or variations of these:

  • Test that the "Refresh Address" button displays and works on HD wallets.
  • Delete the wallet, re-test with a Legacy wallet, ensure the button is hidden.

If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!


@JSKitty JSKitty self-assigned this Nov 13, 2023
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit c1e0088
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/65525e2954fec500082e75d4
😎 Deploy Preview https://deploy-preview-263--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK c1e0088

@JSKitty JSKitty merged commit f07a136 into master Nov 15, 2023
5 checks passed
@JSKitty JSKitty deleted the fix-refresh-address branch November 15, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants