Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Vitest occasionally segfaulted. According to the docs, we were using the default multi threaded pool,
This PR changes the pool to
fork
, which should not have this issue. This incurs approximately a 10% decrease in performance.Additionally, a setup file was added where we setup the happy-dom environment with the correct skeleton, instead of doing it each time per test.
Testing
Run
npm test
a bunch of times, and check that it doesn't segfaut