Skip to content

Commit

Permalink
Merge #2471: [Build] fix GA boost test random seed number overflow
Browse files Browse the repository at this point in the history
c3d0d65 Build: fix GA boost test seed random number overflow. (furszy)

Pull request description:

  The random seed value, used in boost for shuffling the unit tests order, is interpreted as an unsigned int inside the boost test framework and the current value is overflowing the type range, thus why GA is failing in every PR and commit.

  Solution: use the framework functionality to select a random seed based on the current time (can check it inside boost documentation [link](https://www.boost.org/doc/libs/1_76_0/libs/test/doc/html/boost_test/utf_reference/rt_param_reference/random.html)).

ACKs for top commit:
  random-zebra:
    ACK c3d0d65

Tree-SHA512: 369ff23da2d40e3c19319ba49e99c45a8575967e9c375c8b6d7294df041c53e0f39b6738d70de651d274e74e9a6964e295c4252ded24981a2cd1b96f6dc095fd
  • Loading branch information
furszy committed Jul 6, 2021
2 parents 0bb0135 + c3d0d65 commit dfe6d4c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ jobs:
CCACHE_COMPRESS: 1
PARAMS_DIR: ${{ github.workspace }}/.pivx-params
WINEDEBUG: fixme-all
BOOST_TEST_RANDOM: 1${{ github.run_id }}
BOOST_TEST_RANDOM: 1 # random seed based on the current time
defaults:
run:
shell: bash
Expand Down

0 comments on commit dfe6d4c

Please sign in to comment.