Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI][Trivial] :: Language for the dismiss help box says Exit - confusing? #1658

Closed
sabhiram opened this issue Jun 2, 2020 · 2 comments
Closed

[GUI][Trivial] :: Language for the dismiss help box says Exit - confusing? #1658

sabhiram opened this issue Jun 2, 2020 · 2 comments

Comments

@sabhiram
Copy link

sabhiram commented Jun 2, 2020

Should this be Close or Dismiss or an X instead of Exit? This made me feel like the whole app was going to maybe close. Feel free to close this if this is an outdated opinion :)

Screenshots.

image

What version of PIVX Core are you using?

4.1.1
@Crypto-SI
Copy link

Simple fix would be change the wording to either "Exit FAQ" or "Return to wallet"?

This could be a good 'First issue' also.

@sabhiram
Copy link
Author

Exit FAQ has my vote :)

@furszy furszy mentioned this issue Nov 17, 2020
Merged
furszy added a commit that referenced this issue Nov 17, 2020
@furszy
Merge #1978: [GUI] FAQ "Exit" moved to "Close FAQ"
f6a1a6e 
75259b7 GUI: FAQ "Exit" moved to "Close FAQ" (furszy)

Pull request description:

  Closing #1658

ACKs for top commit:
  random-zebra:
    utACK 75259b7
  Fuzzbawls:
    utACK 75259b7

Tree-SHA512: 458a9b98e3b12d7c2cd7d9bfc44a95418d39899e5f76e3c42576a469bfb2c15460875e44617c78bf616f4efd003abf67d9898a2e4f88a6855ca4acdad9e747e9
@furszy furszy closed this as completed Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sabhiram @furszy @Crypto-SI