[RFC] Bump minimum required Boost version to 1.57.0 #1682
Comments
|
ACK on bumping the minimum required boost version to 1.57 |
|
ACK on bumping the min version to 1.57 too. Another good discussion would be the upgrade to c++17 to be able to use std::optional instead of boost::optional (as well as many others objects/functions like the variant, visitor pattern, etc). |
random-zebra
added a commit
that referenced
this issue
Jul 15, 2020
44c13ee Travis: Remove trusty test target (Fuzzbawls) 9c6cb1b Doccument the minimum boost version bump (Fuzzbawls) e0d5271 Enforce that no deprecated boost filesystem methods can be re-introduced (Fuzzbawls) c9f53b5 Stop using deprecated boost filesystem methods (Fuzzbawls) 85210ec Build: Remove redundant configure-time boost fallbacks (Fuzzbawls) 35748bb Build: Remove old boost version precompiler fallbacks (Fuzzbawls) 249c442 Build: Set minimum Boost version to 1.57.0 (Fuzzbawls) Pull request description: This implements a minimum required boost version bump, pursuant to #1682 The configure script has been updated to require a detected version of at least 1.57.0, and now-redundant sub-checks have been removed. Precompiler macros that offered version or feature fallbacks have also been largely removed as they are unnecessary. Finally, this also updates some Boost Filesystem Path codebase that was using deprecated methods, and sets the `BOOST_FILESYSTEM_NO_DEPRECATED` macro so that such methods do not get re-added to the codebase in the future. Ready for review, but should not be merged until after the `4.2` branch-off. ACKs for top commit: furszy: utACK 44c13ee random-zebra: utACK 44c13ee and merging... Tree-SHA512: 2491625f21f488bcec025f75eebfd50a571a6c896892f6c902febf1ed2262e453ed71c4c1f5ae2901e30c5f4a2f58c404851995b31008d66b40fd59b98fb82c5
|
PR merged, closing issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, our minimum required Boost version is 1.47.0 in order to continue support primarily for Ubuntu Trusty, which reached the end of it's standard support April 2019.
In our upcoming sapling implementation, we rely on a
boost::optionalmethod that doesn't exist until Boost 1.57.0. This issue proposes to bump up our minimum required Boost version to 1.57.0 rather than create a workaround.This will effectively end our support for the following distros unless compiling with the
dependssystem:* This is probably the most controversial, as CentOS 7 is still in wide use; CentOS 8 was only released in Sept 2019.
The text was updated successfully, but these errors were encountered: