Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup][Refactor]Main.cpp code cleanup. #1066

Merged
merged 1 commit into from
Nov 12, 2019
Merged

[Cleanup][Refactor]Main.cpp code cleanup. #1066

merged 1 commit into from
Nov 12, 2019

Conversation

furszy
Copy link

@furszy furszy commented Oct 28, 2019

  • Not used GetInputAgeIX method removed.
  • AcceptToMemoryPool HasZerocoinSpendInputs code duplication.
  • Several for loops copying variable cleaned.

@furszy furszy self-assigned this Oct 28, 2019
random-zebra
random-zebra reviewed Oct 28, 2019
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
@random-zebra random-zebra added this to the 4.0.0 milestone Oct 28, 2019
@furszy
[Cleanup][Refactor][Performance] Main.cpp code cleanup:
0cf9bb0 
* Not used GetInputAgeIX method removed.
* AcceptToMemoryPool HasZerocoinSpendInputs code duplication.
* Several for loops copying the variable cleaned.
@furszy furszy force-pushed the 2019_main.cpp_minor_cleanup branch from a54b7f3 to 0cf9bb0 Compare November 4, 2019 13:53
random-zebra
random-zebra approved these changes Nov 10, 2019
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0cf9bb0

Warrows
Warrows approved these changes Nov 12, 2019
View reviewed changes
Copy link

@Warrows Warrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0cf9bb0

furszy added a commit that referenced this pull request Nov 12, 2019
@furszy
Merge #1066: [Cleanup][Refactor]Main.cpp code cleanup.
6a4bf7c 
0cf9bb0 [Cleanup][Refactor][Performance] Main.cpp code cleanup: * Not used GetInputAgeIX method removed. * AcceptToMemoryPool HasZerocoinSpendInputs code duplication. * Several for loops copying the variable cleaned. (furszy)

Pull request description:

  * Not used GetInputAgeIX method removed.
  * AcceptToMemoryPool HasZerocoinSpendInputs code duplication.
  * Several for loops copying variable cleaned.

ACKs for top commit:
  random-zebra:
    ACK 0cf9bb0
  Warrows:
    ACK 0cf9bb0

Tree-SHA512: fc443266b34e3730ad5d9ed2d698ef101cef4d8565b8070a0da6df9139201c4af5b1f6e992b24f3e8a009c8d56df14e1d14b3a620a05fa17d5ac3f08fa12e3d3
@furszy furszy merged commit 0cf9bb0 into PIVX-Project:master Nov 12, 2019
@lyricidal lyricidal mentioned this pull request Mar 8, 2022
Merged
@furszy furszy deleted the 2019_main.cpp_minor_cleanup branch November 29, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Warrows Warrows Warrows approved these changes

@random-zebra random-zebra random-zebra approved these changes

Assignees

@furszy furszy

Labels
Cleanup Refactoring
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@furszy @Warrows @random-zebra