[Wallet] Enable miner with mnsync incomplete #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when sporks 8, 9 and 13 are disabled
furszy
approved these changes
Nov 5, 2019
Warrows
approved these changes
Nov 10, 2019
random-zebra
added a commit
that referenced
this pull request
Nov 10, 2019
fe550d4 [Wallet] Enable miner with mnsync incomplete (random-zebra) Pull request description: Instead of outright preventing the generation of new blocks when mnsync is incomplete, use a different logic: prevent the creation of new block when: - mnsync is incomplete **AND** - _either_ the spork list is not synced (we are at the very start of mnsync) _or one_ between sporks 8,9 or 13 is active In other words, try to stake a new block only if - mnsync is complete **OR** - the spork list is synced _and all three_ sporks (8,9 and 13) are not active. ACKs for top commit: furszy: utACK fe550d4 Warrows: utACK fe550d4 Tree-SHA512: f31ab8d1679f49edd5aa6bae88bef67701bd923b95761a7a5853a9110932df0972bb05e3413a981a32bbd62561285329d0ef4cfe264a62e3773cf9e52f2f8979
Fuzzbawls
added
the
Needs Release Notes
Fuzzbawls
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of outright preventing the generation of new blocks when mnsync is incomplete, use a different logic: prevent the creation of new block when:
AND
In other words, try to stake a new block only if
OR