[Backport] 4.0.1 backports #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapcraft nightly build version bump. Missed doing this in PIVX-Project#1200 Github-Pull: PIVX-Project#1204 Rebased-From: 976f16a
We don't need to be including these IDE files in the source repo Github-Pull: PIVX-Project#1205 Rebased-From: b578675
Github-Pull: PIVX-Project#1199 Rebased-From: bccbec4
Large wallets suffer from long loading times as it is, this call to `CheckTransaction()` just adds to that loading time. Github-Pull: PIVX-Project#1222 Rebased-From: 3de6c63
…+ refactor. * Best block cached hash. * csBestBlock, cvBlockChange names updated to latest upstream naming convention. Github-Pull: PIVX-Project#1203 Rebased-From: 4976c0a
…fy the user about its existence. Github-Pull: PIVX-Project#1223 Rebased-From: baa33c3
Github-Pull: PIVX-Project#1206 Rebased-From: ae063d0
Github-Pull: PIVX-Project#1184 Rebased-From: dae64f3
Github-Pull: PIVX-Project#1233 Rebased-From: f9857f7
Github-Pull: PIVX-Project#1224 Rebased-From: 43b783f
…f serialization + hash calculation in every read transaction in the wallet startup. Github-Pull: PIVX-Project#1231 Rebased-From: 24fb46d
…creens support. * Navigation bar scrollable. Github-Pull: PIVX-Project#1228 Rebased-From: 1493b4a
…pamming. Not useful for any user to load into the UI more than 20,000 transaction records, if the wallet has them. Only will make the whole GUI slower and screw the whole user experience. This sets a limit and only shows the latest 20k txs (which is most likely still a big number for any regular user..). Github-Pull: PIVX-Project#1217 Rebased-From: b1aa1e2
Batching items load + uniform item sizes. Github-Pull: PIVX-Project#1217 Rebased-From: 7c9dd0d
… startup. 100 blocks checked for corruption is too much, having only 10 is more than enough to verify the db consistency. Github-Pull: PIVX-Project#1217 Rebased-From: 6d5c84e
Github-Pull: PIVX-Project#1217 Rebased-From: 7a1a639
Precomputing for zPIV spends is no longer used, and the bulk of it's code was simply commented out. This removes the now-dead code, as well as removes the runtime `-precompute` option and it's associated thread. Github-Pull: PIVX-Project#1234 Rebased-From: 2e1c2d0
Bitcoin's PPA is now unmaintained for newer versions of Ubuntu (last supported version was 18.10). The PIVX PPA supports all current Ubuntu versions for providing BDB 4.8.30 (including the upcoming Focal Fossa 20 .04 LTS version). So, update our docs to reference the PIVX PPA. [Docs] Remove OpenSSL 1.1 note from build-unix.md Builds with OpenSSL 1.1 are now possible without an explicit configure override. There is now no need to have this note in the doc. [Docs] Add note about missing Qt Charts system package Ubuntu versions prior to Bionic, and Debian version prior to Buster lack the Qt Charts library, so make note of this in the build doc. [Docs] Add Qt's SVG and Charts libs to fedora build instructions Github-Pull: PIVX-Project#1207 Rebased-From: 9da9329
Github-Pull: PIVX-Project#1238 Rebased-From: 21f1b9d
Github-Pull: PIVX-Project#1238 Rebased-From: 34e871c
Include COLD_STAKING_SEND purpose which has STAKING_ADDRESS prefix Github-Pull: PIVX-Project#1238 Rebased-From: dd7a744
Github-Pull: PIVX-Project#1238 Rebased-From: 768694f
Github-Pull: PIVX-Project#1218 Rebased-From: 261bb6a
Github-Pull: PIVX-Project#1218 Rebased-From: 8f668b6
backports bitcoin/bitcoin 4aabadb Github-Pull: PIVX-Project#1218 Rebased-From: 3c811d1
Github-Pull: PIVX-Project#1218 Rebased-From: af05235
Github-Pull: PIVX-Project#1218 Rebased-From: 80306e1
Github-Pull: PIVX-Project#1218 Rebased-From: afabe8c
Github-Pull: PIVX-Project#1218 Rebased-From: 422f003
Github-Pull: PIVX-Project#1218 Rebased-From: 383ab89
Simply remove `fSignatureCheck` argument in CheckSignature and use mnodeman Github-Pull: PIVX-Project#1243 Rebased-From: b7f59a0
Github-Pull: PIVX-Project#1221 Rebased-From: 621bb06
Github-Pull: PIVX-Project#1221 Rebased-From: 86de445
… status fix + performance improvements. * The transaction record status update was not taking into account the negative depth calculation, neither if it was conflicted, for not accepted coin stakes * GetDepth method was called in three different ways. 1) GetDepthAndMempool, 2) IsTrusted, 3) GetBlocksToMaturity. This PR unifies every call into a single call to IsTrusted(&depth, &fConflicted). * Several calls to chainActive->Height unified into a single one in record statusUpdate. Github-Pull: PIVX-Project#1240 Rebased-From: 0057548
Github-Pull: PIVX-Project#1242 Rebased-From: 144ec35
Github-Pull: PIVX-Project#1242 Rebased-From: 3bd5579
Github-Pull: PIVX-Project#1242 Rebased-From: d1ebf2e
and fix ping message when --keepcache Github-Pull: PIVX-Project#1242 Rebased-From: 96bdd3e
Github-Pull: PIVX-Project#1242 Rebased-From: ce93872
Github-Pull: PIVX-Project#1250 Rebased-From: 0fb3fc4
Github-Pull: PIVX-Project#1245 Rebased-From: 6b2b813
Streamline the logic to update the wallet's staking status using two single variables timeLastStakeAttempt and hashLastStakeAttempt. The Staking Status is Active whenever timeLastStakeAttempt is less than 30 seconds in the past. The logic is implemented with a new class CStakerStatus, member of the wallet. Time and hash are now updated directly in the wallet (CreateCoinStake) instead of in the kernel (Stake) Github-Pull: PIVX-Project#1245 Rebased-From: 01173e9
remove: - nLastCoinStakeSearchTime (and nSearchTime/fStakeFound + if block) - fLastLoopOrphan Github-Pull: PIVX-Project#1245 Rebased-From: dbc46d8
Github-Pull: PIVX-Project#1245 Rebased-From: d2d5f08
Github-Pull: PIVX-Project#1245 Rebased-From: b8ed76f
Github-Pull: PIVX-Project#1245 Rebased-From: d2aebc5
Directly update the staking status icon when the wallet is manually locked so the user doesn't have to wait for the polling timeout and gets instant feedback. Otherwise the wallet would have (even if just for 15-30 seconds) simultaneously the staking icon ON and the lock icon LOCKED, which could be quite confusing. Github-Pull: PIVX-Project#1245 Rebased-From: bb2a987
Github-Pull: PIVX-Project#1245 Rebased-From: 968d861
- remove extra "Update" function and introduce "SetNull" - guard initialization in CWallet::SetNull() - GUI: fix staking icon update when wallet locked - update CStakerStatus time *after* Stake() - RPC: move staking_status to the top Github-Pull: PIVX-Project#1245 Rebased-From: 9362e88
The call is already wrapped in it, no need to check a second time. Further, since the status is get from pwalletMain, throw if it is not loaded. Also move the staking status inside if(pwalletMain) in getinfo Github-Pull: PIVX-Project#1245 Rebased-From: 3893739
Github-Pull: PIVX-Project#1252 Rebased-From: d83e67c
Loading of the cold staking delegations list checks to see if `isLoading` is true, and exit's out if it is. this check is used to prevent double loading, but on some systems `isLoading` is initialized as `true`, so the loading of CS delegations will never occur. This changes to initialization to be explicitly `false`. Github-Pull: PIVX-Project#1253 Rebased-From: d837803
First step in removing the internal accounting system. All RPC command documentation/help output now notates that account arguments are deprecated. Ported from bitcoin#5575, with additional edits where necessary for cold staking related commands that also used account arguments. Github-Pull: PIVX-Project#1251 Rebased-From: 73d331a
Fuzzbawls
added a commit
that referenced
this pull request
Jan 12, 2020
d209897 [RPC] Notate all account stuff as deprecated (Fuzzbawls) 10bbf9e [Qt] Initialize isLoading to false for CS view (Fuzzbawls) b7c63b8 [Trivial] Set log2_work decimals to 16 in the logs Github-Pull: #1252 Rebased-From: d83e67c (random-zebra) a80e2e9 [RPC] Fix getstakingstatus removing compile-time conditional (random-zebra) 876d393 [Wallet][Cleanup][GUI] minor updates to staking status (random-zebra) f9f437a [Wallet] CStakerStatus: save a pointer to the tip instead of the hash Github-Pull: #1245 Rebased-From: 968d861 (random-zebra) f9022cf [GUI] Refactor updateStakingStatus and set it to inactive after locking (random-zebra) cd6f6cb [Trivial] Fix lastHashTime type in miner Github-Pull: #1245 Rebased-From: d2aebc5 (random-zebra) 6845d18 [RPC] Add CStakerStatus data to getstakingstatus Github-Pull: #1245 Rebased-From: b8ed76f (random-zebra) b63d963 [PoS] Lock cs_main when getting chainActive data in miner Github-Pull: #1245 Rebased-From: d2d5f08 (random-zebra) 6fac9b9 [Cleanup] Remove unused variables in miner (random-zebra) 7128945 [Core][PoS] Replace mapHashedBlocks and nLastCoinStakeSearchInterval (random-zebra) c546ac1 [Cleanup][Wallet] Remove unused nSearchInterval field in CreateCoinStake Github-Pull: #1245 Rebased-From: 6b2b813 (random-zebra) 5dbda15 [GUI] Every masternode action checking for tier two network synced. (furszy) 499dac8 [Trivial][RPC] Fix example line in importprivkey help (missing arg) Github-Pull: #1242 Rebased-From: ce93872 (random-zebra) 4133401 [Tests] Add wallet_import_stakingaddress to test runner (random-zebra) 8ac5cbb [Tests] Add functional test for import staking address/key Github-Pull: #1242 Rebased-From: d1ebf2e (random-zebra) bb9426a [RPC] Add coldstaking address support in importaddress Github-Pull: #1242 Rebased-From: 3bd5579 (random-zebra) 3084143 [RPC] Add coldstaking address support in importprivkey Github-Pull: #1242 Rebased-From: 144ec35 (random-zebra) bb021af [Model][Wallet][Performance] TxRecord updateStatus not accepted stake status fix + performance improvements. (furszy) 1f0823f [GUI][Model] Start missing masternodes flow implemented. (furszy) 90639d1 [GUI] Masternodes start all flow implemented. (furszy) 14f3220 [Core] Don't log missing MNs during CBudgetProposal::CleanAndRemove (random-zebra) 7e1b908 [GUI] Translator class abstracted to be able to reuse the ProcessSendCoinsReturn method in the masternodeswizard class. (furszy) fa73ae3 [GUI] Masternode creation wizard, creation fail event properly detailing the failure cause in the subsequent error dialog. (furszy) 447265f [Wallet] Graceful shutdown in the unlock corrupted wallet, showing the proper error message in screen. (furszy) 81cbe1d [Cleanup][Tests] Remove precompute option in default framework node conf Github-Pull: #1237 Rebased-From: 51cbb00 (random-zebra) ded2cc2 [Cleanup] remove fPrecompute option in SelectStakeCoins (random-zebra) 391c9e6 [Cleanup][Tests] Remove crazy useful unittest created by "Tom" Github-Pull: #1237 Rebased-From: 0187f0d (random-zebra) 67411b5 [Cleanup][Wallet] Remove zpiv spend cache from zpiv tracker Github-Pull: #1237 Rebased-From: 29a934c (random-zebra) 7084840 [Cleanup][DB] Remove DB functions for zerocoin precomputing Github-Pull: #1237 Rebased-From: bd3eebb (random-zebra) 1e93feb [Cleanup] Remove zPIV precomputing global variables. Github-Pull: #1237 Rebased-From: 837f4e2 (random-zebra) 4de0dec [Cleanup][Qt] remove COLUMN_PRECOMPUTE from zpivcontroldialog Github-Pull: #1237 Rebased-From: 520284e (random-zebra) 3394078 [Cleanup] Init: remove precompute-related helps in strUsage Github-Pull: #1237 Rebased-From: 2585532 (random-zebra) 7d03510 [Cleanup] Init: remove "precompute" debug category (not used anywhere) Github-Pull: #1237 Rebased-From: fbcf37b (random-zebra) 9ea6aa2 [Tests][BUG] Fix RPC_TRANSACTION_REJECTED in mining_pos_reorg Github-Pull: #1218 Rebased-From: 1fb9dd3 (random-zebra) 44c60dc [Tests] sort exported mints by denom in zc_spends and zc_wrapped_serials (random-zebra) 0538d25 [Tests] Speed up cache generation (random-zebra) 3abe8a8 [Travis][Tests] Add travis ping during create_cache Github-Pull: #1218 Rebased-From: 6a2a3b9 (random-zebra) e6080f4 [RPC][BUG] Remove extra lock in spendrawzerocoin Github-Pull: #1218 Rebased-From: 35ea5bc (random-zebra) 88ddf09 [Tests][Trivial] remove stale zerocoin_publicSpend_reorg (random-zebra) 5c70582 [Tests] Fix and re-enable wrapping serials test Github-Pull: #1218 Rebased-From: 039c220 (random-zebra) fc7069a [RPC] Enable v2 spending on regtest with spendrawzerocoin Github-Pull: #1218 Rebased-From: ddf18d9 (random-zebra) 5a3951a [Tests] Sort test_runner list by execution time (and comment it there) Github-Pull: #1218 Rebased-From: b3af5bd (random-zebra) 248adc5 [Tests] Fix edge case for double spends in zerocoin_spends.py (random-zebra) 66f3cb1 [Tests] Remove zpiv tests from fakestake (random-zebra) 11bc853 [Trivial] Rename base test class in p2p_time_offset functional test Github-Pull: #1218 Rebased-From: cb54381 (random-zebra) 8a25781 [Tests] Refactor POS reorg test (random-zebra) ddc6b8a [Tests] Prefix "_pos_" tests with "_mining_" Github-Pull: #1218 Rebased-From: 384c636 (random-zebra) 97da652 [Tests] Fix wallet_reorg-stake functional test Github-Pull: #1218 Rebased-From: 8949e38 (random-zebra) 807b4ab [Consensus] Fix fake-stake spent serials detection on forked chains Github-Pull: #1218 Rebased-From: 0417f66 (random-zebra) 24bee71 [Tests] Unify and complete FakeStake test suite in a single testcase. Github-Pull: #1218 Rebased-From: d2c1ef2 (random-zebra) 0dc9e17 [Tests] Refactor PIVX tools in test_framework, blocktools and utils Github-Pull: #1218 Rebased-From: b3f0c59 (random-zebra) 07a7081 [RPC][Tests] createrawzerocoinpublicspend --> createrawzerocoinspend (random-zebra) ccd5b80 [Tests] Refactor zerocoin_valid_public_spend into zerocoin_spends (random-zebra) 0b551a9 [Tests] Add zerocoins to PoS cache (random-zebra) ae841ed [RPC] use json object as output of mintzerocoin (random-zebra) 5539b01 [Tests] Restore p2p_zpos_fakestake (random-zebra) 8f84377 [Tests] Lower zerocoin confirmations on regtest (random-zebra) f36a035 [Tests] Fix zerocoin_valid_public_spend with new v3 activation height Github-Pull: #1218 Rebased-From: acf8fea (random-zebra) d7804b7 [Tests] Set public spend activation for regtest to block 400 (from 350) (random-zebra) e8b7ce3 [RPC] Refactor spendzerocoin/spendzcoinmints, fix createrawzerocoinstake (random-zebra) 9134f40 [Tests] Introduce PIVX specific blocktools (random-zebra) 56cfbdd [Tests] Cleanup rpc_spork functional test with new util functions Github-Pull: #1218 Rebased-From: 68ce4e9 (random-zebra) e5e6f28 [Tests] Define spork util functions (random-zebra) ac6f95e [Tests] Use PoS_cache in zerocoin_public_spend Github-Pull: #1218 Rebased-From: 383ab89 (random-zebra) e093f7b [RPC] Add mint txid to spendrawzerocoin (and look for it if empty) Github-Pull: #1218 Rebased-From: 422f003 (random-zebra) 8ebd65a [Trivial] Detailed debug log for received spork messages Github-Pull: #1218 Rebased-From: afabe8c (random-zebra) f669844 [Tests] Define a new 'PoS' cache with 330-blocks chain Github-Pull: #1218 Rebased-From: 80306e1 (random-zebra) 3c84efd [Tests] Fix CheckBlockHeader version after block 300 for regtest Github-Pull: #1218 Rebased-From: af05235 (random-zebra) 3b8de3a [Tests] Have combine_logs default to most recent test dir (random-zebra) baa97af [Tests] rename base class to PivxTestFramework Github-Pull: #1218 Rebased-From: 8f668b6 (random-zebra) ab553bf [Tests] Debug assert_raises_rpc_error Github-Pull: #1218 Rebased-From: 261bb6a (random-zebra) 76531e2 [Cleanup] Replace addr purpose strings with AddressBookPurpose constants Github-Pull: #1238 Rebased-From: 768694f (random-zebra) 09120ce [RPC] Fix Base58Type in ListaddressesForPurpose (random-zebra) 7e32b1e [RPC] Add optional bool arg to listdelegators to show blacklisted addrs Github-Pull: #1238 Rebased-From: 34e871c (random-zebra) 8f01bce [RPC] Add optional str argument to delegatoradd for address label Github-Pull: #1238 Rebased-From: 21f1b9d (random-zebra) bb1c8f2 [Docs] Update build-unix.md (Fuzzbawls) f035a4a [Cleanup] Remove precomputing (Fuzzbawls) ee4aed3 [Trivial] Adding load txs on demand todo text. (furszy) 784094b [Startup] Decrease the amount of blocks checked for corruption in the startup. (furszy) 3b67bc6 [GUI][Performance] Optimizations to every list view load in the GUI. (furszy) 7da7eb7 [Model] Maximum amount of loaded record in ram, preventing any self-spamming. (furszy) aeaf418 [GUI] Adding the capability to decrease the screen size for smaller screens support. (furszy) 2a5d14d [Wallet] IsEquivalentTo commented for now to not add an extra round of serialization + hash calculation in every read transaction in the wallet startup. (furszy) f7a1420 Minor changes within 4.0 wallet FAQ Github-Pull: #1224 Rebased-From: 43b783f (NoobieDev12) 053d365 [Trivial] Remove spammy log in in StakeV1 Github-Pull: #1233 Rebased-From: f9857f7 (random-zebra) 16441e9 [GUI][Trivial] Minor edits to written content Github-Pull: #1184 Rebased-From: dae64f3 (random-zebra) ffac2a7 [BUG][RPC] fix signature check (against old format) in mnbudgetrawvote Github-Pull: #1206 Rebased-From: ae063d0 (random-zebra) e82e2f5 [GUI][Bug] Show locked balance in the available total amount and notify the user about its existence. (furszy) 47d2c40 [Backport][Performance] Cache best block hash for miner thread usage + refactor. (furszy) fe12794 [Wallet] Remove un-necessary CheckTransaction call when loading wallet. (Fuzzbawls) b8f2b1a [Build] Clean up warnings (Cave Spectre) d4e6693 [Cleanup] Remove unnecessary QtCreator files (Fuzzbawls) 361757b [Build] Bump snapcraft nightlies to 4.0.99 (Fuzzbawls) Pull request description: Updates the `4.0` branch with relevant merged PRs in preparation for tagging the `4.0.1` release. Included PRs: #1204 #1205 #1199 #1222 #1203 #1223 #1206 #1184 #1233 #1224 #1231 #1228 #1217 #1234 #1207 #1238 #1218 #1237 #1229 #1211 #1243 #1221 #1240 #1242 #1250 #1245 #1252 #1253 #1251 ACKs for top commit: random-zebra: utACK d209897 Tree-SHA512: 092349a93ea4bfe6d6284d5b996055d2900576fab971707458260a848fbdbb15926b13e6ee46469b283721f7dc51a455f5d209a62d9309caa03cecd3b66bd556
furszy
reviewed
Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
4.0branch with relevant merged PRs in preparation for tagging the4.0.1release.Included PRs:
#1204
#1205
#1199
#1222
#1203
#1223
#1206
#1184
#1233
#1224
#1231
#1228
#1217
#1234
#1207
#1238
#1218
#1237
#1229
#1211
#1243
#1221
#1240
#1242
#1250
#1245
#1252
#1253
#1251