Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
RPCWallet: Notate all account stuff as deprecated #5575
I have an alternative suggestion here, namely to 'degrade' accounts back into labels. That means marking all RPC methods that operate on the concept of an "account balance" as deprecated, but not the ability to list transactions received with a particular label etc.
Pro: address labels already exist in the GUI and we probably want to keep them there, so making the RPC functionality analogous should be easy, and it doesn't have the potential confusion risk that accounts have.
I like sipa's idea. The labels feature is useful, and aiming to expose it eventually in both RPC and the GUI would make things symmetrical, which is what many users expect.
On the other hand doing that without confusing current users of accounts even more will be difficult. Hence I like first communicating a complete deprecation of the account system as in this pull.
Then introduce a new API for labels. This also makes it clear that the label system is separately useful and not just 'degraded accounts'. The usual warning apply - "don't use this at the same time as the account system, or it will get confused".
As there would no longer be a concept of 'account address' or 'account balance' the label API could be very minimal, e.g.:
These would stay the same, and accept a label instead of an account:
added a commit
this pull request
Jan 8, 2015
What would be the point of getaccountaddress without accounts? Why not use
Well, the concept of a 'label address' just doesn't make sense, and also has no GUI equivalent.
Also there is some weird interaction that prevents the last address from being moved from an account, and that interaction has to do with the 'account address'. To make it work like GUI labels (so you can get rid of them by renaming), that would have to be changed as well. Easiest would be to just get rid of the confusing feature.