Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Quick minor GUI startup useful changes. #1266

Merged
merged 2 commits into from
Jan 14, 2020

Conversation

furszy
Copy link

@furszy furszy commented Jan 14, 2020

Two simple changes:

  1. App's window opening in the smallest possible size if the screen size is lower than our base height.

  2. NavMenu was not showing the dashboard button due the new scroll area in the startup, this fixes it.

@furszy furszy self-assigned this Jan 14, 2020
@random-zebra random-zebra added this to the 4.0.2 milestone Jan 14, 2020
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7c524b9

Copy link

@Mrs-X Mrs-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with a little nit: can't hurt (and wouldn't be much work) to do the same for the width as well.
But for now I can live with that as it is, though. BASE and MIN would probably be the same anyway...

random-zebra added a commit that referenced this pull request Jan 14, 2020
7c524b9 [GUI] Force NavMenu to show dashboard button at startup. (furszy)
80e1531 [GUI] Open the app's window in the smallest, currently available, size. (furszy)

Pull request description:

  Two simple changes:

  1) App's window opening in the smallest possible size if the screen size is lower than our base height.

  2) NavMenu was not showing the dashboard button due the new scroll area in the startup, this fixes it.

ACKs for top commit:
  random-zebra:
    ACK 7c524b9

Tree-SHA512: 6b504fb95c1e5614f4954065fb1e3238d930dc8619ac6dc10c415fb500ca447738c12dad07e79d321a053149291b792606013ac8a9dfc03181a03a98dd397b09
@random-zebra random-zebra merged commit 7c524b9 into PIVX-Project:master Jan 14, 2020
Fuzzbawls pushed a commit to Fuzzbawls/PIVX that referenced this pull request Jan 16, 2020
Fuzzbawls pushed a commit to Fuzzbawls/PIVX that referenced this pull request Jan 16, 2020
furszy added a commit that referenced this pull request Jan 16, 2020
4663310 [GUI] Min window size (furszy)
5c76d51 Doc: Update manpages for 4.0.2 (Fuzzbawls)
79bfec9 Build: Bump version to 4.0.2 (Fuzzbawls)
82d0af7 Doc: Update release notes for 4.0.2 (Fuzzbawls)
3432e29 [GUI] Transaction record cold staking fixes. (furszy)
e5badbc [RPC] Don't do extra PoW round for pos blocks in 'generate' RPC Github-Pull: #1274 Rebased-From: 6b5ce00 (random-zebra)
7b8169c [Trivial] Update copyright headers for 4.0.2 (Fuzzbawls)
8faf4bf [Core] Update checkpoints for first v7 block (Fuzzbawls)
f6e8a14 [GUI] Add latest block number to topbar pushButtonSync Github-Pull: #1268 Rebased-From: 84b4ae4 (random-zebra)
8edfa83 [GUI] Connect P2CSUnlockOwner and P2CSUnlockStaker records to the model Github-Pull: #1265 Rebased-From: 4b24380 (random-zebra)
e475827 [GUI] CoinControlDialog, removing extra spacing char from the copy to clipboard texts. (furszy)
dbe2b3a [GUI] CoinControlDialog, copy to clipboard action implemented on every showed label + inform snackbar notifying the user. (furszy)
3404bd9 [Wallet] Don't add P2CS automatically to CWalletTx::GetLockedCredit Github-Pull: #1264 Rebased-From: 4789652 (random-zebra)
d1f5731 [GUI] Force NavMenu to show dashboard button at startup. (furszy)
cdee261 [GUI] Open the app's window in the smallest, currently available, size. (furszy)
fc766c8 [GUI] TransactionRecord type P2CSDelegationSentOwner and P2CSDelegationSent distinction. (furszy)
49de2e4 [Qt][Bug] Load the most recent instead of the first transactions (Fuzzbawls)
827ca3e [Bug][GUI] Double counted delegated balance fix. (furszy)

Pull request description:

  Updates the `4.0` branch with relevant merged PRs in preparation for tagging the `4.0.2` release.

  Included PRs:
  #1261
  #1267
  #1263
  #1266
  #1264
  #1269
  #1265
  #1268
  #1273
  #1272
  #1274
  #1279

Top commit has no ACKs.

Tree-SHA512: 561d9319d08756c040751c6ce145505610ed2ebc4351a87d9d3bb05ecb98df9f35d492e9e3eb7e111ce611268c4a24bb13720e3f81917a671038f8ab23f14de4
@furszy furszy deleted the 2020_gui_minor_fixes branch November 29, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants