Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Display latest block number in the top bar #1268

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

random-zebra
Copy link

Quick one. setNumBlocks is already connected.
Just need to set the text.

Preview:
Screenshot from 2020-01-14 14-45-36

@random-zebra random-zebra added this to the 4.0.2 milestone Jan 14, 2020
@random-zebra random-zebra self-assigned this Jan 14, 2020
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

src/qt/pivx/topbar.cpp Outdated Show resolved Hide resolved
Mrs-X
Mrs-X previously approved these changes Jan 14, 2020
Copy link

@Mrs-X Mrs-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b3f88d2

@CaveSpectre11
Copy link

ACK 84b4ae4

Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 84b4ae4

furszy added a commit that referenced this pull request Jan 15, 2020
84b4ae4 [GUI] Add latest block number to topbar pushButtonSync (random-zebra)

Pull request description:

  Quick one. `setNumBlocks` is already connected.
  Just need to set the text.

  Preview:
  ![Screenshot from 2020-01-14 14-45-36](https://user-images.githubusercontent.com/18186894/72349351-a9575780-36dc-11ea-9c4c-becfca99fff1.png)

ACKs for top commit:
  CaveSpectre11:
    ACK 84b4ae4
  furszy:
    ACK 84b4ae4

Tree-SHA512: ed1737712d5b547e974be75d8cbc7120c2896fe607f85af0c9f31da523e745e6029c231b1cb92042031a262f85b601bb8f4c5a6f17244382d4b4d40b65b42be0
@furszy furszy merged commit 84b4ae4 into PIVX-Project:master Jan 15, 2020
Fuzzbawls pushed a commit to Fuzzbawls/PIVX that referenced this pull request Jan 16, 2020
furszy added a commit that referenced this pull request Jan 16, 2020
4663310 [GUI] Min window size (furszy)
5c76d51 Doc: Update manpages for 4.0.2 (Fuzzbawls)
79bfec9 Build: Bump version to 4.0.2 (Fuzzbawls)
82d0af7 Doc: Update release notes for 4.0.2 (Fuzzbawls)
3432e29 [GUI] Transaction record cold staking fixes. (furszy)
e5badbc [RPC] Don't do extra PoW round for pos blocks in 'generate' RPC Github-Pull: #1274 Rebased-From: 6b5ce00 (random-zebra)
7b8169c [Trivial] Update copyright headers for 4.0.2 (Fuzzbawls)
8faf4bf [Core] Update checkpoints for first v7 block (Fuzzbawls)
f6e8a14 [GUI] Add latest block number to topbar pushButtonSync Github-Pull: #1268 Rebased-From: 84b4ae4 (random-zebra)
8edfa83 [GUI] Connect P2CSUnlockOwner and P2CSUnlockStaker records to the model Github-Pull: #1265 Rebased-From: 4b24380 (random-zebra)
e475827 [GUI] CoinControlDialog, removing extra spacing char from the copy to clipboard texts. (furszy)
dbe2b3a [GUI] CoinControlDialog, copy to clipboard action implemented on every showed label + inform snackbar notifying the user. (furszy)
3404bd9 [Wallet] Don't add P2CS automatically to CWalletTx::GetLockedCredit Github-Pull: #1264 Rebased-From: 4789652 (random-zebra)
d1f5731 [GUI] Force NavMenu to show dashboard button at startup. (furszy)
cdee261 [GUI] Open the app's window in the smallest, currently available, size. (furszy)
fc766c8 [GUI] TransactionRecord type P2CSDelegationSentOwner and P2CSDelegationSent distinction. (furszy)
49de2e4 [Qt][Bug] Load the most recent instead of the first transactions (Fuzzbawls)
827ca3e [Bug][GUI] Double counted delegated balance fix. (furszy)

Pull request description:

  Updates the `4.0` branch with relevant merged PRs in preparation for tagging the `4.0.2` release.

  Included PRs:
  #1261
  #1267
  #1263
  #1266
  #1264
  #1269
  #1265
  #1268
  #1273
  #1272
  #1274
  #1279

Top commit has no ACKs.

Tree-SHA512: 561d9319d08756c040751c6ce145505610ed2ebc4351a87d9d3bb05ecb98df9f35d492e9e3eb7e111ce611268c4a24bb13720e3f81917a671038f8ab23f14de4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants