[GUI] Hide privacy widget when the wallet has no zPIV balance #1306
Conversation
Fuzzbawls
changed the title
|
Think there needs to be a refresh after loading the wallet model. After initial startup and loading, the menu button is unstyled (see image) until i click on any menu button.
Other than that, works as intended. |
furszy
force-pushed
the
2020_hide_privacy_if_no_balance
branch
from
feb42c5
to
aec179f
Compare
furszy
force-pushed
the
2020_hide_privacy_if_no_balance
branch
from
aec179f
to
a453fa9
Compare
|
Done, updated as per @Fuzzbawls's comment. |
|
Something to note, would be good as a follow up to this: A wallet that at one point contained zPIV and has since spent/converted all of them will no longer have access to the "Privacy" tab (as it is being hidden/disabled in this PR when zPIV balance is 0). As a consequence, the user also looses access to viewing the wallet's zPIV transaction history list. The main overview page should probably add zPIV transactions back into it's list to display, and also allow for filtering by these types of transactions.. |
|
The wallet is currently displaying all of the zPIV transactions in the dashboard list. Only the list filter action is missing. Can definitely be added in another PR, pretty straightforward change. |
…lance a453fa9 [GUI] Hide privacy widget whether the wallet has no zc balance (furszy) Pull request description: Auto-descriptive title. if the wallet has not zPIV, the privacy widget is not presented in the screen, nor loaded into ram. ACKs for top commit: Fuzzbawls: ACK a453fa9 random-zebra: ACK a453fa9 and merging... Tree-SHA512: 5c9addcc08bafc11caf16fa579ea337b06e90168fd69e5322e08df796b8016cd2b680559118cc8180c8da895711e93b10c602634329bc23648ac7f6518f17011
Auto-descriptive title.
if the wallet has not zPIV, the privacy widget is not presented in the screen, nor loaded into ram.