[Qt] Hide zPIV balances when they are zero #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. Good follow-up on #1306 |
furszy
reviewed
Feb 7, 2020
Since there will be no **new** zerocoins anymore, there is no need to take up UI space with zero value zerocoin balance information.
Fuzzbawls
force-pushed
the
2020_hide-zpiv-balance
branch
from
606c732
to
cd1f806
Compare
furszy
approved these changes
Feb 17, 2020
random-zebra
added a commit
that referenced
this pull request
Feb 19, 2020
cd1f806 [Qt] Hide zPIV balances when they are zero (Fuzzbawls) Pull request description: Since there will be no **new** zerocoins anymore, there is no need to take up UI space with zero value zerocoin balance information. This hides the related UI labels if/when the wallet doesn't have any zerocoin balance. Before:  After:  ACKs for top commit: furszy: Code looking good, utACK cd1f806 random-zebra: ACK cd1f806 and merging... Tree-SHA512: 84fdfa7790d137efe319e7da8caf9f46a7787f51de7feb7ce164c738ac4f002515d3946857a1837d18480d88e49e62e43457de755d436922e7ce229ca736498e
Fuzzbawls
added
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there will be no new zerocoins anymore, there is no need to
take up UI space with zero value zerocoin balance information.
This hides the related UI labels if/when the wallet doesn't have any zerocoin
balance.
Before:
After:
