[Cleanup] Remove stale UNITTEST network #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This network is un-necessary as our unit test suite can simply be run with MainNet's parameters, which is basically what we already do.
furszy
approved these changes
Feb 13, 2020
furszy
added a commit
that referenced
this pull request
Feb 13, 2020
bf74c6f [Cleanup] Remove stale UNITTEST network (Fuzzbawls) Pull request description: This network is un-necessary as our unit test suite can simply be run with MainNet's parameters, which is basically what we already do. Minor conflict with #1328 due to that PR having already removed one of the unused methods. ACKs for top commit: random-zebra: utACK bf74c6f furszy: utACK bf74c6f and merging.. Tree-SHA512: 1b8c7b4178e2dc8d60fe89b4ce4d4ad476f433ced19d981e1d3e1043fd8468e269600fcbe30ee04f7954250a183f2bc34486ad9b37fd7d78aed828c47d662d77
random-zebra
added a commit
that referenced
this pull request
Feb 18, 2020
47f552d [Cleanup] Remove MineBlocksOnDemand function in chainparams (random-zebra) Pull request description: The only network where fMineBlocksOnDemand is true is regtest (unittest network was removed in #1330 ) Just use IsRegTestNet function. ACKs for top commit: furszy: utACK 47f552d Tree-SHA512: 95bc644532675a55098e1836286b15c462221879b25018c0f89c3c9bcd626556b928d65641996ff41aad34460c2f1940390479575e4845aa43e742409832c1a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This network is un-necessary as our unit test suite can simply be run
with MainNet's parameters, which is basically what we already do.
Minor conflict with #1328 due to that PR having already removed one of the unused methods.