Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Remove MineBlocksOnDemand function in chainparams #1340

Merged
merged 1 commit into from
Feb 18, 2020
Merged

[Cleanup] Remove MineBlocksOnDemand function in chainparams #1340

merged 1 commit into from
Feb 18, 2020

Conversation

random-zebra
Copy link

The only network where fMineBlocksOnDemand is true is regtest (unittest network was removed in #1330 )
Just use IsRegTestNet function.

@random-zebra
[Cleanup] Remove MineBlocksOnDemand function in chainparams
47f552d 
The only network that can mine blocks on demand is regtest.
Just use IsRegTestNet function.
@random-zebra random-zebra added Cleanup Trivial extremely simple issues labels Feb 17, 2020
@random-zebra random-zebra added this to the 4.1.0 milestone Feb 17, 2020
@random-zebra random-zebra self-assigned this Feb 17, 2020
furszy
furszy approved these changes Feb 17, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 47f552d

random-zebra added a commit that referenced this pull request Feb 18, 2020
@random-zebra
Merge #1340: [Cleanup] Remove MineBlocksOnDemand function in chainparams
57cf8a6 
47f552d [Cleanup] Remove MineBlocksOnDemand function in chainparams (random-zebra)

Pull request description:

  The only network where fMineBlocksOnDemand is true is regtest (unittest network was removed in #1330 )
  Just use IsRegTestNet function.

ACKs for top commit:
  furszy:
    utACK 47f552d

Tree-SHA512: 95bc644532675a55098e1836286b15c462221879b25018c0f89c3c9bcd626556b928d65641996ff41aad34460c2f1940390479575e4845aa43e742409832c1a0
@random-zebra random-zebra merged commit 47f552d into PIVX-Project:master Feb 18, 2020
@random-zebra random-zebra deleted the 2020_MineBlocksOnDemand branch September 24, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furszy furszy furszy approved these changes

Assignees

@random-zebra random-zebra

Labels
Cleanup Trivial extremely simple issues
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@random-zebra @furszy