[Bug] nStakeSplitThreshold: division by zero #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a zero nStakeSplitThreshold value to disable stake-split feature
random-zebra
added
RPC
Bug
Wallet
Block Generation
furszy
approved these changes
Feb 19, 2020
Fuzzbawls
approved these changes
Feb 20, 2020
|
utACK 4829b35 |
|
Merging... |
furszy
added a commit
that referenced
this pull request
Mar 1, 2020
6f05f01 [Doc] changes to Stake-Split threshold and related RPC (random-zebra) c9ec304 [Wallet][RPC][GUI] nStakeSplitThreshold as CAmount (random-zebra) Pull request description: Follow-up on #1343 - Wallet: save/use nStakeSplitThreshold as CAmount - RPC: setstakesplitthreshold takes decimal values - RPC: getstakesplitthreshold returns a double - GUI: widget in settingsoptions changed to QDoubleSpinBox - GUI: QSetting saved as double. ACKs for top commit: Fuzzbawls: ACK 6f05f01 furszy: Left a tiny correction for later, the rest is working fine. ACK 6f05f01 Tree-SHA512: dc4d6a1a55c6ce11a6fb5a6a2c78e1fe4ea0905fb3ca1d3d085984533a820eea960caec919b61cf73f1868ffac926f4d0b5eff2cf27248194d297d8c0cc10326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC should accept only values between 1 and 999999 (as per
setstakesplitthresholdhelp) but the input provided was only checked against the upper bound.Setting a 0 value would result in a crash (division-by-zero) at the first stake.
Now prevent the wallet from splitting the stake if the threshold is set to zero.
Future work:
There is no reason why the split threshold should be an integer.
Make it
CAmountand enable decimal values for it.Also use
JSONRPCError(RPC_INVALID_PARAMETER)instead of runtime errors when the input is not valid.