[Wallet][RPC][GUI] nStakeSplitThreshold as CAmount #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wallet: save/use nStakeSplitThreshold as CAmount - RPC: setstakesplitthreshold takes decimal values - RPC: getstakesplitthreshold returns a double - GUI: widget in settingsoptions changed to QDoubleSpinBox - GUI: QSetting saved as qlonglong.
|
Wouldn't be better to remove the |
Fuzzbawls
approved these changes
Mar 1, 2020
furszy
approved these changes
Mar 1, 2020
| <widget class="QSpinBox" name="spinBoxStakeSplitThreshold"> | ||
| <widget class="QDoubleSpinBox" name="spinBoxStakeSplitThreshold"> | ||
| <property name="decimals"> | ||
| <number>3</number> |
There was a problem hiding this comment.
Should be using the display decimal digits stored field instead of a fixed one (Plus, the default value is 2 decimals).
Inside the SettingsWalletOptionsWidget class, ui->spinBoxStakeSplitThreshold->setDecimals(2)
random-zebra
added a commit
that referenced
this pull request
Mar 2, 2020
e29ea53 [Doc] Add change to default stake-split threshold value (random-zebra) cb16380 [GUI] Do not save stake-split threshold in QSettings (random-zebra) 7aaa1cc [Wallet] Lower DEFAULT_STAKE_SPLIT_THRESHOLD from 2000 down to 500 (random-zebra) Pull request description: - Lower default value of stake-split threshold - Do not save it directly in QSettings (just in the wallet db). Built on #1345 Closes #1350 ACKs for top commit: furszy: utACK e29ea53. Fuzzbawls: ACK e29ea53 Tree-SHA512: 6197ee7e8270de2b3905c427a8b003be32a5020266a4b57709a09c0194a3e253cf574cba9e12efce8afbf360602947648427aa891d900ab5077cc476585d99c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #1343