Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Don't initialize zpivwallet on first run #1382

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

Fuzzbawls
Copy link
Collaborator

With zPIV minting being disabled, there is no reason to initialize the zPIV wallet nor a default mint pool.

This simply disables that flow.

@Fuzzbawls Fuzzbawls added this to the 4.1.0 milestone Mar 5, 2020
@Fuzzbawls Fuzzbawls self-assigned this Mar 5, 2020
@Fuzzbawls Fuzzbawls changed the title [Net] Add support for dnsseeds with option to filter by servicebits [Wallet] Don't initialize zpivwallet on first run Mar 5, 2020
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup. Only one comment.

src/init.cpp Outdated Show resolved Hide resolved
@Fuzzbawls
Copy link
Collaborator Author

first iteration of this was a bit too aggressive with code removal. we need to maintain the ability to mint zerocoins for regtest...at least for the time being.

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ACK a01f23d

Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, ACK a01f23d.

@furszy furszy merged commit df2db0d into PIVX-Project:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants