[Trivial] Remove spammy log in CheckSignature #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
approved these changes
Mar 25, 2020
Fuzzbawls
approved these changes
Mar 27, 2020
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 30, 2020
e2c3e77 [Trivial] Remove spammy log in CheckSignature (random-zebra) Pull request description: Remove extra logs in `CSignedMessage::CheckSignature`. This method is inherited by all classes extending `CSignedMessage` and its log does not give useful information to the verifier at all (it's not even clear what is the class in question). Might just be of some help when signing (`VerifyHash` is called from within `CSignedMessage::Sign` too). All relevant logs for verifiers are already provided by the caller - e.g. ```cpp if (!mess.CheckSignature()) { /* log something */ } ``` ACKs for top commit: furszy: utACK e2c3e77. Fuzzbawls: utACK e2c3e77 Tree-SHA512: cf7e24aed86f26f6895289ebc07ece268864836f954372db4834e94f7aac9192bd97d6dec6269efe9c3ee6ce601a8fabd2fc98b29c91e6230bfb9d0386d06727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove extra logs in
CSignedMessage::CheckSignature.This method is inherited by all classes extending
CSignedMessageand its log does not give useful information to the verifier at all (it's not even clear what is the class in question). Might just be of some help when signing (VerifyHashis called from withinCSignedMessage::Signtoo).All relevant logs for verifiers are already provided by the caller - e.g.