[Wallet] Clean wrong pwalletMain inside wallet class. #1495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially
wallet.cpp
,crypter.cpp
andwallet_zerocoin.cpp
were wrongly using/callingpwalletMain
when those files are actually THE WALLET.This was blocking the
CWallet
object usage in unit test as the wallet (or any other wallet created that it's notpwalletMain
) would be calling a pointer that could or couldn't exist when it should just call an internal method.