[Qt] Fixup filter dropdown localizations #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to avoid errors when updating our main localization source file with `make translate`
furszy
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address type filter dropdown items and the sorting method dropdown items weren't available for localization.
Additionally, the transaction type filter dropdown items were using a call method that isn't supported by Qt's linquist utility program (which we use to generate the updated localization source file as part of
make translate).Finally, the file was not in compliance with our coding style guidelines, so the first commit is a reformat-only commit which can be duplicated by running the following command on
master:clang-format -i src/qt/pivx/qtutils.*(minor blank-line changes were made afterwards in the header include section of
qtutils.h)