forked from dashpay/dash
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P2P] Enforce expected outbound services #1616
Merged
random-zebra
merged 6 commits into
PIVX-Project:master
from
Fuzzbawls:2020_checkservices
May 13, 2020
Merged
[P2P] Enforce expected outbound services #1616
random-zebra
merged 6 commits into
PIVX-Project:master
from
Fuzzbawls:2020_checkservices
May 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 12, 2020
furszy
approved these changes
May 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one-one with 7749 with the only exception of the tier two area, looks good, utACK a48639f
Update network code from upstream
automation
moved this from In progress
to Reviewer approved
May 13, 2020
random-zebra
approved these changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. ACK a48639f and merging...
furszy
added a commit
that referenced
this pull request
May 14, 2020
…ults 9107379 Do not set extra flags for unfiltered DNS seed results (Pieter Wuille) Pull request description: Backport of bitcoin#8208 based on top of #1616 (Only the last commit is important here). Part of #1374. Original Description: > Any flag set in nRelevantServices would propagate to all CAddress results retrieved from the DNS seed, even if that DNS seed does not support filtering. > > Fix this by making the name adaptation function also update the passed in flags. > > Furthermore, move that from from DNSSeedData to net. Structs in chainparams should be data only. ACKs for top commit: random-zebra: utACK 9107379 furszy: utACK 9107379 Tree-SHA512: a4c75fcdabac7afbd5df4b33f0bd02a438dffa75b8b63bc49fe63998579c8a15d6067cc357a72efd0b8123c9708853b9e2d04eada7ae85c088b0952bcf0baa90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of bitcoin#7749. This is next in line for #1374.
Original description: