[GUI] Better start single MN error description. #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
changed the title
|
can be rebased now that #1719 has been merged |
furszy
force-pushed
the
2020_gui_mn_start_error
branch
from
3908123
to
1d42014
Compare
|
rebased |
Fuzzbawls
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1719 .
Fixing/Improving a bad error notification string showed in the GUI due the
CMasternodeBroadcast::CreatecallingCWallet::GetMasternodeVinAndKeysand returning to the GUI the same string error output that is being printed to the log (with all of the extra data, including function names, service etc..).Can be easily tested creating a masternode, then not waiting for the 15 confirmations and trying to start the node via the menu single masternode start (click on the masternode row and then press start).
Without the last commit, will popup a bad error notification text.