Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] save historical rel notes for 4.2.0 and reset template #1772

Merged
merged 1 commit into from
Jul 29, 2020
Merged

[Doc] save historical rel notes for 4.2.0 and reset template #1772

merged 1 commit into from
Jul 29, 2020

Conversation

random-zebra
Copy link

Basic maintenance PR. Save release notes of PIVX Core wallet v. 4.2.0 in the doc/release-notes directory, and cleanup the template file doc/release-notes.md.

@random-zebra random-zebra added this to the 5.0.0 milestone Jul 29, 2020
@random-zebra random-zebra self-assigned this Jul 29, 2020
furszy
furszy approved these changes Jul 29, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9e1a045

@random-zebra random-zebra mentioned this pull request Jul 29, 2020
Merged
3 tasks
Fuzzbawls
Fuzzbawls approved these changes Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9e1a045

@random-zebra random-zebra merged commit 91c373c into PIVX-Project:master Jul 29, 2020
furszy added a commit that referenced this pull request Aug 19, 2020
@furszy
Merge #1773: [Core] per-txout model preparation
90ffc66 
83512d2 [Trivial] Mark CCoinsView child classes methods as override (random-zebra)
5643075 Store/allow tx metadata in all undo records (random-zebra)
8c4add4 Report on-disk size in gettxoutsetinfo (random-zebra)
6cb2989 Remove/ignore tx version in utxo and undo (random-zebra)
03b9724 Add specialization of SipHash for 256 + 32 bit data (Pieter Wuille)
e3cd496 Introduce CHashVerifier to hash read data (random-zebra)
10baa70 error() in disconnect for disk corruption, not inconsistency (random-zebra)
802f8c8 Add SizeEstimate to CDBBatch (Pieter Wuille)

Pull request description:

  This backports the commits listed as "Preparation" in bitcoin#10195.
  The rest will be included in a followup PR.

  Built on top of:
  - [x] #1772
  - [x] #1771
  - [x] #1793

  Here we:
  - add in-memory size estimation of a LevelDB batch
  - remove the usage of `error()` in ApplyTxInUndo/DisconnectBlock
  - Introduce the new CHashVerifier class to hash read data
  - Add a specialized version of SipHash for tuples of 256 bits and 32 bits data
  - Remove the transaction version from utxo and undo data structures
  - Add on-disk size of the utxo set to gettxoutsetinfo
  - store tx metadata in all undo records, instead of records corresponding only to the last output of a tx being spent.

ACKs for top commit:
  furszy:
    looking good, utACK 83512d2.
  Fuzzbawls:
    utACK 83512d2

Tree-SHA512: 7db730058ae208535aad5f5989abb9c55fd3722b79efef24fdd8c717687b67272bddaeae5e5a4a2d3e97626a7ec62a5d1ebdb5af0233f4a950b5a0c0b154484f
@random-zebra random-zebra modified the milestones: 5.0.0, 4.3.0 Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furszy furszy furszy approved these changes

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

Assignees

@random-zebra random-zebra

Labels
Documentation NoFunctionalChanges Trivial extremely simple issues
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@random-zebra @furszy @Fuzzbawls