[Build] allow for empty RUST_TARGET in offline builds #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RUST_TARGET variable only applies when cross-compiling. Build systems like launchpad and copr don't cross compile, but also need pre-vendored rust sources as they don't allow network access during the build stage. In this situation, the RUST_TARGET variable is empty.
|
the result of this work can be seen tested at https://code.launchpad.net/~fuzzbawls/+recipe/piv-test |
furszy
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RUST_TARGET variable only applies when cross-compiling. Build
systems like launchpad and copr don't cross compile, but also need
pre-vendored rust sources as they don't allow network access during the
build stage. In this situation, the RUST_TARGET variable is empty.
This will fix our nightly PPA builds on Launchpad, and is supported by
additional changes in my
pivx-packagingrepo, as well as a newrust-vendored-sourcesrepo, both hosted on launchpad.A separate PR will
be made to fix our nightly Snap builds, which will either entail re-working
how those builds are done, or rewrite the
rust.mkdescriptor.