[Wallet] Address book encapsulation. #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase |
furszy
force-pushed
the
2020_wallet_encapsulate_mapAddressBook
branch
from
f97ed1c
to
264d331
Compare
|
rebased |
random-zebra
reviewed
Sep 7, 2020
random-zebra
suggested changes
Sep 7, 2020
furszy
force-pushed
the
2020_wallet_encapsulate_mapAddressBook
branch
from
264d331
to
17b57b9
Compare
|
updated following the feedback 👌 |
furszy
force-pushed
the
2020_wallet_encapsulate_mapAddressBook
branch
3 times, most recently
from
c659294
to
735c169
Compare
random-zebra
reviewed
Sep 9, 2020
furszy
force-pushed
the
2020_wallet_encapsulate_mapAddressBook
branch
from
735c169
to
8b5eaf7
Compare
|
updated solving all of the comments 👍 |
furszy
force-pushed
the
2020_wallet_encapsulate_mapAddressBook
branch
from
8b5eaf7
to
01bf9ff
Compare
furszy
force-pushed
the
2020_wallet_encapsulate_mapAddressBook
branch
from
01bf9ff
to
6fb8f1f
Compare
…meForAddressBookEntry(dest)
… loop to use it. refactor: move remaining mapAddressBook direct access to GetAddressBookXXX encapsulation methods.
furszy
force-pushed
the
2020_wallet_encapsulate_mapAddressBook
branch
from
6fb8f1f
to
e0ffc98
Compare
|
rebased on master due conflicts with recently merged #1853 plus cleaned a previous refactor that wasn't needed anymore in Ready for review. |
furszy
requested review from
random-zebra
and removed request for
random-zebra
random-zebra
previously approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Looks good.
There is still some recursive locking (e.g. HasAddressBook or GetNameForAddressBookEntry), but those can be fixed later.
Same as a couple comments left inline.
ACK e0ffc98
furszy
force-pushed
the
2020_wallet_encapsulate_mapAddressBook
branch
from
e0ffc98
to
f7e997f
Compare
|
Done, updated the two lines changes. A quick git diff and can be re acked. |
Fuzzbawls
approved these changes
Sep 22, 2020
Fuzzbawls
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially, have restricted
mapAddressbookaccess to the wallet class only. Migrating every direct access to the correspondent getter, setter and iterator wrapper. Plus, solved a todo inAddressTableModel::getAddressToShow(df262e4).It's a preparation for the shielded addresses addressbook support.