[Wallet] Sapling keys management final round. #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these maps are created from scratch on wallet load, so we can alter their contents without compatibility concerns. With this change, we can use the existing maps to implement viewing key support. The downside is that the wallet will take more space in memory, but that can easily be improved in future by storing ExtFVK fingerprints in some of the maps (which would improve memory usage even compared to the original layout). Coming from zcash@d74fdd76eb1707012beed1eba1e9ab83cf6ea5b5
Now that we store SaplingExtendedFullViewingKey internally, we have access to the default address everywhere we require it. Coming from zcash@b62bb98087a83d8bb9c1ff7669d34b9ca9adbaf4
Coming from zcash@7de06244e6a874cd468bad021b7537d5909c1b71
furszy
force-pushed
the
2020_sapling_wallet_keys
branch
2 times, most recently
from
fd0033b
to
de5872d
Compare
Fuzzbawls
changed the title
|
travis job solved, ready for review. |
furszy
requested review from
random-zebra and
Fuzzbawls
and removed request for
Fuzzbawls and
random-zebra
Fuzzbawls
reviewed
Oct 8, 2020
furszy
force-pushed
the
2020_sapling_wallet_keys
branch
from
de5872d
to
1b63091
Compare
|
updated per feedback. |
Fuzzbawls
previously approved these changes
Oct 8, 2020
random-zebra
reviewed
Oct 9, 2020
furszy
force-pushed
the
2020_sapling_wallet_keys
branch
from
1b63091
to
5cb4144
Compare
|
Updated per feedback. |
random-zebra
reviewed
Oct 9, 2020
furszy
force-pushed
the
2020_sapling_wallet_keys
branch
from
5cb4144
to
9bfa1d6
Compare
|
updated per feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoupled from #1798, purely focused on the wallet's Sapling keys area. On four main aspects:
Sapling keys management refactored to support viewing key functionality.
New RPC commands implemented:
exportsaplingkey,importsaplingkey,importsaplingviewingkeyandexportsaplingviewingkey.RPC commands expanded adding sapling keys support capabilities:
dumpwalletandimportwallet.Implemented unit test coverage for:
getnewshieldedaddresson an encrypted and unencrypted wallet,listsaplingaddresses,importsaplingkey,exportsaplingkeyvia rpc calls.Extra data:
Further down 1798 road, we will get even more testing coverage for this features like #1798/c5d4ffe3, plus a test coverage expansion for Sapling keys in
importwalletanddumpwallet. (cannot add them here because they are depending on the shielded_spend functionality that will treat in another decouplement PR round).The list of decoupled commits from #1798 is the following one:
SaplingFullViewingKey -> SaplingExtendedFullViewingKey in keystore maps —> a98a0be
Remove default address parameter from Sapling keystore methods —> 96d30a7
test: Add test for CBasicKeyStore::AddSaplingFullViewingKey —> 21f683c
Add encoding and decoding for Sapling extended full viewing keys. —> 7da9de3
[Wallet] Do not add a sapling key if the sspkm is not enabled. —> 9ad9572
GetSpendingKeyForPaymentAddress method implemented —> f1d6646
RPC: Implement exportsaplingkey —> 2eb2a3a
wallet: AddSpendingKeyToWallet method implemented. —> e66acfd
adding exportsaplingkey command to the rpcwallet table —> 368c0d0
RPC: importsaplingkey command implemented. —> 3e4b1ba
dumpwallet including sapling keys —> 30336c1
importwallet including sapling keys —> 519b78c
importsaplingviewingkey RPC command implemented. —> 4323b2d
RPC: exportsaplingviewingkey command back ported —> a38da6a
Sapling logging type added. —> b301ff6
rpc_wallet_getnewsaplingaddress test implemented. —> 102c760
rpc_wallet_encrypted_wallet_sapzkeys test included. —> d461836
Test: sapling wallet import/export keys implemented. —> 8792587
importsaplingkey RPC command unit test —> 67f7993