[BugFix] Shutdown, stop threadGroup before dump data to disk. #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise threads will continue modifying data structures while the dump process is being executed.
Fuzzbawls
approved these changes
Feb 10, 2021
This was referenced Feb 14, 2021
random-zebra
added a commit
that referenced
this pull request
Mar 12, 2021
ca3edc5 GUI: Update worker type if task already exist. (furszy) a1390c3 wallet balances, cache total delegated balance and calculate it only once. (furszy) 02eb781 GUI: settings information, do not update block num and block hash if the screen is not visible. (furszy) cbc5021 Masternode-sync read only function to get the "IsBlockchainSynced" state. (furszy) ef77fdf GUI: topbar, removing not used block source. (furszy) e9c160a wallet: single loop to calculate the currently required balances. (furszy) 32538ae wallet: Disallow abandon of conflicted txes (furszy) 62cd35f GUI: MN model, remove now unneeded cs_main locks. (furszy) 5658844 wallet: removing unnecessary `mempool.cs` lock from ReacceptWalletTransactions() (furszy) 63f3fa7 GUI: add missing qt metatype declarations. (furszy) bc76186 wallet model: update delay increased to 5 seconds. (furszy) 3fb3f34 GUI dashboard: do not update the staking filter if it's not needed. (furszy) 7cb8276 init: move "Done loading" message and rpc warm up finished after the wallet post initialization process (furszy) 8762e81 Refactoring with QString::toNSString (Hennadii Stepanov) 69b3330 GUI: txmodel, do not lock cs_wallet if no wtx status update is needed. (furszy) b4ab286 GUI: dashboard, charts update delay time increased for IBD. (furszy) 0f197ca Wallet interface: do not load not used cold staking balances. (furszy) dee4224 Wallet:GetLockedCoins() loop only over the locked coins, not over the entire wallet txes map. (furszy) 0a61f7f GUI: cold staking, do not refresh delegations if the screen is not visible. (furszy) c2d66d0 GUI: cold staking screen, do not initialize coin control dialog at startup. (furszy) 44d9cbe GUI: dashboard screen, remove stakes filter source model if chart is not being presented. (furszy) 6e49a11 GUI: send screen, initialize coinControlDialog view only when it's being called. (furszy) 379e5f2 GUI: send screen, move refresh amounts calculation to a background worker thread. (furszy) 76bc08b GUI: balance polling update moved to a background worker thread. (furszy) b73500a wallet:BlockConnected do not lock cs_wallet for its entire process. (furszy) 208a292 wallet: remove last cs_main locks from every signal handler function :) . (furszy) 9720579 SSPKM: remove redundant ReadBlockFromDisk from IncrementNoteWitnesses. (furszy) 4ccec74 wallet: Add IsSpent() cs_wallet lock assertion. (furszy) e0a0d2d sapling_wallet_tests: locking order refactor, solving inconsistent orders for cs_main and cs_wallet. (furszy) c69e7e8 Adapt sapling_wallet_listreceived.py to the new wtx confirmation structure. (furszy) c4952a2 Wallet::CreateWalletFromFile guard direct chainActive access (furszy) f889dcb test : updating wallet's last block processed manually. (furszy) 45c9471 wallet: split CheckTXAvailability in two. (furszy) 5109c8d Wallet: remove cs_main from IsSaplingSpent() and GetFilteredNotes() (furszy) a7f6ab1 Wallet: remove cs_main requirement from RelayWalletTransaction and FundTransaction. (furszy) 1e7ffc2 Wallet: remove cs_main requirement from CreateCoinStake (furszy) 2e7cdb2 Wallet: added max value out filter for AvailableCoins. (furszy) b9220f4 Wallet: Do not add P2CS utxo to autocombine flow and discard them later. (furszy) 59ed47d Wallet: remove cs_main lock from AutoCombineDust plus a redundant maturity check. (furszy) fcc4c83 Move AutoCombineDust functionality to the wallet background thread (furszy) fcb20c2 GUI: remove cs_main lock dependency from CWalletModel::isSpent, CWalletModel::isLockedCoin, CWalletModel::lockCoin, CWalletModel::unlockCoin (furszy) 65fbad1 GUI: remove cs_main lock dependency from transaction model update. (furszy) 0b61857 GUI: fix coinstake tx ordering. (furszy) 33588fe GUI: Remove cs_main lock and chain dependency from transaction update status (furszy) 3dede64 GUI: Remove cs_main lock from balance polling timer (furszy) 5e06330 Removed IsFinalTx() cs_main lock requirement. (furszy) 1bd97ca wallet::MarkConflicted remove blockIndex and there by cs_main lock dependency. (furszy) 239d6a2 wallet: remove the now unneeded cs_main locks (furszy) 1386ab7 Use CWallet::m_last_block_processed_height in GetDepthInMainChain (furszy) 9adeb61 Only return early from BlockUntilSyncedToCurrentChain if current tip is exact match (furszy) 8aa2d31 Add block_height field in struct Confirmation (furszy) 4405ac0 Replace CWalletTx::SetConf by Confirmation initialization list (furszy) 6320efb Update wallet last processed index in every unit test that needs it (furszy) 4957051 wallet: cache block hash, height and time inside the wallet. (furszy) 33f4788 wallet: refactor GetDepthInMainChain to not return the block index. (furszy) e7c8ca6 wallet: remove unused IsInMainChain method (furszy) 9e51a48 Add a test wallet_reorgsrestore (Antoine Riard) 370c200 wallet: simplifying pindexRescan set + added an AssertLockHeld on FindForkInGlobalIndex (furszy) 46f0e30 Fixing reindex problem, use mapBlockIndex.find() and not mapBlockIndex[] (furszy) da78039 [Wallet] Adapting TransactionAddedToMempool and BlockDisconnected to the new wtx confirmation status (furszy) ff04fa6 Modify wallet tx status if has been reorged out (furszy) f7baeaf Remove SyncTransaction for conflicted txn in CWallet::BlockConnected (Antoine Riard) 8d8928e Encapsulate tx status in a Confirmation struct (Antoine Riard) Pull request description: This is the conclusion of a deep deep rabbit hole: #1726, #2150, #2082, #2118, #2150, #2179, #2191, #2192, #2195, #2201, #2203.. Effectively removing every `cs_main` lock from the wallet and GUI processing threads. Completely decoupling the wallet state and the visual interface update procedures from the main message and validation handler thread. Meaning that the messages & validation handler thread will be largely more active, accepting and verifying way more data in less time, not being affected by several other threads accessing to the main critical section. And, at the same time, the wallet and GUI worker threads will be able to perform and process their tasks concurrently, without waiting for the `cs_main` mutex acquisition. Improving the overall software performance, the GUI responsiveness and decreasing the synchronization time. To make this possible, the wallet is maintaining in memory a view of the chain and updating it only via the validation interface signals. Using the view to perform all of the chain related calculations. ACKs for top commit: Fuzzbawls: All good now, ACK ca3edc5 random-zebra: ACK ca3edc5 and merging... Tree-SHA512: 6d4268730941822942b0df0aab200683a1fabaf6801618cf34955b43b29bc2beb694567635f731a724abf7b73cec3edfe506e0428de6710c0fcf603613f5614a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the shutdown process, stop every thread before dump data to disk, otherwise threads will continue modifying data structures while and after the dump process is being / was executed, ending up not storing all of the data and/or corrupting the node state.