Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Add search option to My Addresses list in receive widget (PicklesRcool) #2353

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

random-zebra
Copy link

This is an updated version of #2250 :

  • remove un-needed width increment in receivewidget.ui
  • squashed the commits down to one
  • push under @PicklesRcool's authorship

@random-zebra random-zebra added this to the 6.0.0 milestone Apr 29, 2021
@random-zebra random-zebra self-assigned this Apr 29, 2021
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 274fb26 .
Nice work @PicklesRcool 👌 .

@random-zebra
Copy link
Author

Yup, thanks @PicklesRcool . Merging...

@random-zebra random-zebra merged commit ee9f73c into PIVX-Project:master Apr 30, 2021
@random-zebra random-zebra added the Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes label Apr 30, 2021
furszy referenced this pull request in furszy/bitcoin-core Jun 18, 2021
@random-zebra random-zebra modified the milestones: 6.0.0, 5.2.0 Jun 18, 2021
furszy added a commit that referenced this pull request Jun 19, 2021
3344fb3 [CI] Remove Ubuntu 16.04 from GA workflow, has been deprecated by GA and will be removed on September 20, 2021. (furszy)
b5a8638 [GUI] Cleanup compiler warnings in qtutils.h/cpp (furszy)
73b56e9 [GUI] Fix invisible text due an invalid transparent selection color. (furszy)
df5d820 budget: fixing a possible race condition that could cause a good peer being banned. (furszy)
a5fd073 Fix minimize and close bugs (furszy)
b516e36 depends: update Qt 5.9 source url (Kittywhiskers Van Gogh)
18f4b4a BugFix: fix not updating GUI balance race condition. (furszy)
2c923ed scripted-diff: Replace 'NULL' with 'nullptr' in guiutil.cpp (random-zebra)
7b8b23a Fix memory leaks in qt/guiutil.cpp (Dan Raviv)
cbd5c78 Add search option to My Addresses list in receive widget (Volodia)
0dcbea2 [build] depends macOS: point --sysroot to SDK (Sjors Provoost)
3b542fc [Doc] remove old gitian keys. (furszy)
0f099e8 [GUI] Generate FAQ answer content programmatically (Fuzzbawls)
8483861 qt:Show the entire Window when double clicking on taskbar (ken2812221)
998c7e8 [GUI] fix QT 5.15 `currentIndexChanged(QString)` deprecated method call. (furszy)

Pull request description:

  List of straightforward PRs back ported from v6.0 into the v5.2 branch (ordered by merge date).

  * #2259.
  * #2260.
  * #2348
  * #2350
  * #2353
  * #2305
  * #2374
  * #2379
  * #2384
  * #2377
  * #2395
  * #2401
  * #2413

ACKs for top commit:
  random-zebra:
    utACK 3344fb3
  Fuzzbawls:
    utACK 3344fb3

Tree-SHA512: 4317e83d4c1228b8ae20dc1bc5c8e43ac87598d4d9d9244fdd032f2a0c5eccd1a7ed27bc29094c7411dd653b187c728ab31d732ea686abda15228920a390e4e1
@random-zebra random-zebra removed the Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes label Aug 24, 2021
furszy added a commit that referenced this pull request Sep 23, 2021
bca9c68 [Refactor] Use simpler connect syntax for ReceiveWidget::filterChanged (random-zebra)
6141257 [GUI] Add address search option in cold-staking widget (random-zebra)

Pull request description:

  Same as the one introduced for the receive widget in #2353.
  Closes #2499.

ACKs for top commit:
  Fuzzbawls:
    ACK bca9c68
  furszy:
    tested ACK bca9c68 and merging..

Tree-SHA512: d7a7192110ebe2303030023d31743a06ab6f1b204c0a82103bf0be0444591d1590c452f3703cbcbbfb069d0890b22a5d073b08e1c85f3571388c2f1e5cf41a1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants