Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pivx-cli better error handling + libevent RAII upstream backports #2579

Merged
merged 10 commits into from
Nov 22, 2021

Conversation

@furszy furszy self-assigned this Oct 1, 2021
@furszy furszy force-pushed the 2021_pivx_cli_error_handling branch from d4ac427 to 7d58cd0 Compare October 1, 2021 01:40
@furszy furszy added the Upstream label Oct 1, 2021
@furszy furszy added this to the 6.0.0 milestone Oct 8, 2021
tuladhar and others added 5 commits October 21, 2021 10:41
…ndler to get a more detailed error message if the HTTP request fails.

Coming from btc@381826dfee6258accafac29eef93ad264a90aaf6
Mix of btc@8f329f991bc81ddcfb4f51574e2003edde14e996 and btc@fe37fbe606f099e81c693fae248c23c8f8fd5735
Coming from btc@7f7f102b8d5024cc702e308f2ad86a4137d790f7
@furszy furszy force-pushed the 2021_pivx_cli_error_handling branch from 7d58cd0 to 96991e6 Compare October 21, 2021 13:41
random-zebra
random-zebra previously approved these changes Nov 11, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 96991e6

src/test/raii_event_tests.cpp Outdated Show resolved Hide resolved
@furszy furszy force-pushed the 2021_pivx_cli_error_handling branch from 96991e6 to b4de8aa Compare November 11, 2021 13:59
@furszy
Copy link
Author

furszy commented Nov 11, 2021

squashed feedback in 0d4e7ae.

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK b4de8aa

@furszy furszy modified the milestones: 6.0.0, 5.4.0 Nov 19, 2021
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b4de8aa

@Fuzzbawls Fuzzbawls merged commit e679ccf into PIVX-Project:master Nov 22, 2021
@furszy furszy deleted the 2021_pivx_cli_error_handling branch November 29, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants