bitcoin-cli: More detailed error reporting #8722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK but looks like your are using functions not available in the libevent version travis compiles against (evhttp_request_error) https://travis-ci.org/bitcoin/bitcoin/jobs/159869918#L1081 |
|
Somehow I was afraid of that, all of the useful stuff in libevent is in the alpha/beta branch these days... deja vu to #7759. |
laanwj
force-pushed
the
2016_09_cli_http_error
branch
from
8157648
to
719ebf1
Compare
|
I've guarded the uses of evhttp error with |
Register a evhttp error handler to get a more detailed error message if the HTTP request fails.
laanwj
force-pushed
the
2016_09_cli_http_error
branch
from
719ebf1
to
381826d
Compare
|
Ok I've slightly tweaked the error messages and rebased. This should be ready to go. |
laanwj
added a commit
that referenced
this pull request
Sep 26, 2016
381826d bitcoin-cli: More detailed error reporting (Wladimir J. van der Laan)
Closed
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 22, 2017
libevent-based http server Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5677 - bitcoin/bitcoin#6695 - bitcoin/bitcoin#6899 - bitcoin/bitcoin#7016 - bitcoin/bitcoin#7964 - bitcoin/bitcoin#8722 - bitcoin/bitcoin#8730 - bitcoin/bitcoin#9073 - bitcoin/bitcoin#9265 - bitcoin/bitcoin#9387 - bitcoin/bitcoin#9471 - bitcoin/bitcoin#9647 - bitcoin/bitcoin#9903 Closes #1593 and #1856.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 25, 2017
libevent-based http server Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5677 - bitcoin/bitcoin#6695 - bitcoin/bitcoin#6899 - bitcoin/bitcoin#7016 - bitcoin/bitcoin#7964 - bitcoin/bitcoin#8722 - bitcoin/bitcoin#8730 - bitcoin/bitcoin#9073 - bitcoin/bitcoin#9265 - bitcoin/bitcoin#9387 - bitcoin/bitcoin#9471 - bitcoin/bitcoin#9647 - bitcoin/bitcoin#9903 - bitcoin/bitcoin#6640 - bitcoin/bitcoin#8139 - bitcoin/bitcoin#8839 Closes #1593 and #1856.
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 11, 2018
381826d bitcoin-cli: More detailed error reporting (Wladimir J. van der Laan)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
381826d bitcoin-cli: More detailed error reporting (Wladimir J. van der Laan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register a evhttp error handler to get a more detailed error message if the HTTP request fails. This can save a lot of confusion, distinguishing between, say, timeouts and being unable to connect and HTTP header issues.
Only works for libevent >= 2.1.3.
The rationale for this was to be able to debug the
zuissue leading to #8730. Without this, there is no way to distinguish a refused connection from a HTTP parsing isue.