[RPC] Shield address setlabel/getaddressesbylabel #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
force-pushed
the
2021_rpc-setlabel-shield
branch
from
46b0b17
to
31eff06
Compare
This adds shield address support to the `setlabel` and `getaddressesbylabel` RPC commands. `setlabel` now accepts and validates shield address input argument, where `getaddressesbylabel` now returns shield addresses with a label matching the input argument.
Fuzzbawls
force-pushed
the
2021_rpc-setlabel-shield
branch
from
31eff06
to
db68b90
Compare
furszy
approved these changes
Nov 19, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds shield address support to the
setlabelandgetaddressesbylabelRPC commands.setlabelnow accepts and validatesshield address input argument, where
getaddressesbylabelnow returnsshield addresses with a label matching the input argument.
Companion to #2600 that allows CLI users to set a label for shield addresses
after-the-fact, as well as see shield addresses with an assigned label in the
response of
getaddressesbylabelAlso added relevant release notes for the changes in #2600.
Regression tests added as well to cover the
setlabelcommand.